From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29685 invoked by alias); 1 Aug 2019 14:41:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29676 invoked by uid 89); 1 Aug 2019 14:41:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Aug 2019 14:41:33 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE02F307D98F; Thu, 1 Aug 2019 14:41:31 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-200.ams2.redhat.com [10.36.116.200]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F44C600C4; Thu, 1 Aug 2019 14:41:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x71EfSwE004473; Thu, 1 Aug 2019 16:41:29 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x71EfQhd004472; Thu, 1 Aug 2019 16:41:26 +0200 Date: Thu, 01 Aug 2019 14:41:00 -0000 From: Jakub Jelinek To: Martin =?utf-8?B?TGnFoWth?= Cc: Jan Hubicka , Jeff Law , gcc-patches@gcc.gnu.org, Michael Matz , Richard Biener Subject: Re: [PATCH] Properly detect working jobserver in gcc driver. Message-ID: <20190801144126.GC2726@tucnak> Reply-To: Jakub Jelinek References: <20190731073407.GU15878@tucnak> <20190731080809.g2uerujjqvsaut74@kam.mff.cuni.cz> <20190731085757.GX15878@tucnak> <20190731091215.f5yjjaevmvhiyma4@kam.mff.cuni.cz> <20190801131932.GA2726@tucnak> <089f4b9d-a29a-5031-a272-e005cb5ce78c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <089f4b9d-a29a-5031-a272-e005cb5ce78c@suse.cz> User-Agent: Mutt/1.11.3 (2019-02-01) X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00043.txt.bz2 On Thu, Aug 01, 2019 at 04:34:09PM +0200, Martin Liška wrote: > Ok, after deeper discussion with Honza, I would like to suggest the original > patch that was about proper detection of jobserver. > > Can you please Jakub test the patch in your environment? Isn't this done too late (as in, doesn't the driver at that moment already have some files newly openend, like e.g. the @ option files? > + = ((sscanf (n, "--jobserver-auth=%d,%d", &rfd, &wfd) == 2) No need to wrap sscanf (...) == 2 into ()s. Also, you've already done a strstr, what is the point in verifying it once again that it starts with --jobserver-auth= string? And in the lto-writer.c code there is no space between sscanf and (. Jakub