From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25155 invoked by alias); 3 Aug 2019 20:52:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25147 invoked by uid 89); 3 Aug 2019 20:52:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=ugly X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 03 Aug 2019 20:52:28 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x73KqMtg017762; Sat, 3 Aug 2019 15:52:23 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x73KqL4m017761; Sat, 3 Aug 2019 15:52:21 -0500 Date: Sat, 03 Aug 2019 20:52:00 -0000 From: Segher Boessenkool To: "Kewen.Lin" Cc: GCC Patches , Jakub Jelinek , Richard Biener , richard.sandiford@arm.com, Bill Schmidt Subject: Re: [PATCH V5, rs6000] Support vrotr3 for int vector types Message-ID: <20190803205221.GE31406@gate.crashing.org> References: <20190717134025.GJ20882@gate.crashing.org> <83f8448e-3c59-8991-2176-729d87e08a86@linux.ibm.com> <20190718194818.GT20882@gate.crashing.org> <20190719150647.GZ20882@gate.crashing.org> <20190725134958.GR20882@gate.crashing.org> <20190726141004.GA31406@gate.crashing.org> <85937573-94ae-8a13-2cf6-5d4b9edf97e2@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85937573-94ae-8a13-2cf6-5d4b9edf97e2@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00199.txt.bz2 Hi! I somehow lost track of this email, sorry. On Fri, Aug 02, 2019 at 04:59:44PM +0800, Kewen.Lin wrote: > As to the predicate name and usage, I checked the current vector shifts, > they don't need to check const_vector specially (like right to left > conversion), excepting for the one "vec_shr_", but it checks for > scalar const int. I don't understand why we want to expand rotate-by-vector-of-immediates if we have no insns for that? If you just use vint_operand, what happens then? > Btw, I've changed the > + rtx imm_vec = > + simplify_const_unary_operation > back to > + rtx imm_vec > + = simplify_const_unary_operation > Otherwise check_GNU_style will report "Trailing operator" error. :( Yeah I got it the wrong way around. Either way is ugly. Oh well. > +/* { dg-options "-O3" } */ > +/* { dg-require-effective-target powerpc_altivec_ok } */ If you use altivec_ok, you need to use -maltivec in the options, too. This test should probably work with -O2 as well; use that, if possible. > +/* { dg-require-effective-target powerpc_p8vector_ok } */ I don't think we need this anymore? Not sure. Segher