From: Jakub Jelinek <jakub@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Richard Biener <rguenther@suse.de>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs
Date: Sun, 04 Aug 2019 17:23:00 -0000 [thread overview]
Message-ID: <20190804172251.GN2726@tucnak> (raw)
In-Reply-To: <CAFULd4ams5g7J0PwqDpn-cPZcVa9niTqw5_BWVzGg6MtcDi8sQ@mail.gmail.com>
On Sun, Aug 04, 2019 at 07:11:01PM +0200, Uros Bizjak wrote:
> Yes, the approach looks OK to me. It makes chain building mode
> agnostic, and the chain building can be used for
> a) DImode x86_32 (as is now), but maybe 64bit minmax operation can be added.
> b) SImode x86_32 and x86_64 (this will be mainly used for SImode
> minmax and surrounding SImode operations)
> c) DImode x86_64 (also, mainly used for DImode minmax and surrounding
> DImode operations)
>
> > Still need help with the actual patterns for minmax and how the splitters
> > should look like.
>
> Please look at the attached patch. Maybe we can add memory_operand as
> operand 1 and operand 2 predicate, but let's keep things simple for
> now.
Shouldn't it be used also for p{min,max}ud rather than just p{min,max}sd?
What about p{min,max}{s,u}{b,w,q}? Some of those are already in SSE.
If the conversion of the chain fails, couldn't the STV pass split those
SImode etc. min/max patterns into code with branches, rather than turn it
into cmovs?
Jakub
next prev parent reply other threads:[~2019-08-04 17:23 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 14:03 Richard Biener
2019-07-24 9:14 ` Richard Biener
2019-07-24 11:30 ` Richard Biener
2019-07-24 15:12 ` Jeff Law
2019-07-27 10:07 ` Uros Bizjak
2019-08-09 22:15 ` Jeff Law
2019-07-25 9:15 ` Martin Jambor
2019-07-25 12:57 ` Richard Biener
2019-07-27 11:14 ` Uros Bizjak
2019-07-27 18:23 ` Uros Bizjak
2019-07-31 12:01 ` Richard Biener
2019-08-01 8:54 ` Uros Bizjak
2019-08-01 9:28 ` Richard Biener
2019-08-01 9:38 ` Uros Bizjak
2019-08-03 17:26 ` Richard Biener
2019-08-04 17:11 ` Uros Bizjak
2019-08-04 17:23 ` Jakub Jelinek [this message]
2019-08-04 17:36 ` Uros Bizjak
2019-08-05 8:47 ` Richard Biener
2019-08-05 9:13 ` Richard Sandiford
2019-08-05 10:08 ` Uros Bizjak
2019-08-05 10:12 ` Richard Sandiford
2019-08-05 10:24 ` Uros Bizjak
2019-08-05 10:39 ` Richard Sandiford
2019-08-05 11:50 ` Richard Biener
2019-08-05 11:59 ` Uros Bizjak
2019-08-05 12:16 ` Richard Biener
2019-08-05 12:23 ` Uros Bizjak
2019-08-05 12:33 ` Uros Bizjak
2019-08-08 16:23 ` Jeff Law
2019-08-05 12:44 ` Uros Bizjak
2019-08-05 12:51 ` Uros Bizjak
2019-08-05 12:54 ` Jakub Jelinek
2019-08-05 12:57 ` Uros Bizjak
2019-08-05 13:04 ` Richard Biener
2019-08-05 13:09 ` Uros Bizjak
2019-08-05 13:29 ` Richard Biener
2019-08-05 19:35 ` Uros Bizjak
2019-08-07 9:52 ` Richard Biener
2019-08-07 12:04 ` Richard Biener
2019-08-07 12:11 ` Uros Bizjak
2019-08-07 12:42 ` Uros Bizjak
2019-08-07 12:58 ` Uros Bizjak
2019-08-07 13:00 ` Richard Biener
2019-08-07 13:32 ` Uros Bizjak
2019-08-07 14:15 ` Richard Biener
2019-08-09 7:28 ` Uros Bizjak
2019-08-09 10:13 ` Richard Biener
2019-08-09 10:26 ` Jakub Jelinek
2019-08-09 11:15 ` Richard Biener
2019-08-09 11:06 ` Richard Biener
2019-08-09 13:13 ` Richard Biener
2019-08-09 14:39 ` Uros Bizjak
2019-08-12 12:57 ` Richard Biener
2019-08-12 14:48 ` Uros Bizjak
2019-08-13 16:28 ` Jeff Law
2019-08-13 20:07 ` H.J. Lu
2019-08-15 9:24 ` Uros Bizjak
2019-08-13 15:20 ` Jeff Law
2019-08-14 9:15 ` Richard Biener
2019-08-14 9:36 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190804172251.GN2726@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).