From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56119 invoked by alias); 6 Aug 2019 19:44:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56103 invoked by uid 89); 6 Aug 2019 19:44:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 19:44:10 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55398300C03B; Tue, 6 Aug 2019 19:44:09 +0000 (UTC) Received: from redhat.com (unknown [10.20.4.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E52061000324; Tue, 6 Aug 2019 19:44:08 +0000 (UTC) Date: Tue, 06 Aug 2019 20:04:00 -0000 From: Marek Polacek To: Paolo Carlini Cc: GCC Patches , Jason Merrill Subject: Re: C++ PATCH for c++/91264 - detect modifying const objects in constexpr Message-ID: <20190806194406.GM28284@redhat.com> References: <20190731192659.GP32749@redhat.com> <736a18cd-8fd2-2c37-db3f-a334555897e1@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <736a18cd-8fd2-2c37-db3f-a334555897e1@oracle.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SW-Source: 2019-08/txt/msg00413.txt.bz2 On Tue, Aug 06, 2019 at 09:38:35PM +0200, Paolo Carlini wrote: > Hi, > > On 31/07/19 21:26, Marek Polacek wrote: > > +static void > > +modifying_const_object_error (tree expr, tree obj) > > +{ > > + location_t loc = cp_expr_loc_or_loc (expr, input_location); > > Nit: now we have cp_expr_loc_input_loc Ah yeah, and I was meaning to update it! Will fix. Marek