From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116312 invoked by alias); 12 Aug 2019 09:10:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 50232 invoked by uid 89); 12 Aug 2019 09:03:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_NEUTRAL autolearn=ham version=3.3.1 spammy=Gary, gary X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Aug 2019 09:03:03 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hx6EB-0005v6-BT for gcc-patches@gcc.gnu.org; Mon, 12 Aug 2019 05:02:56 -0400 Received: from rock.gnat.com ([2620:20:4000:0:a9e:1ff:fe9b:1d1]:33465) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hx6EB-0005rn-1g for gcc-patches@gcc.gnu.org; Mon, 12 Aug 2019 05:02:55 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C1CAE560C4; Mon, 12 Aug 2019 05:02:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EXpucDwBcZEX; Mon, 12 Aug 2019 05:02:50 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id ACDCD560C2; Mon, 12 Aug 2019 05:02:50 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4862) id ABBB36AF; Mon, 12 Aug 2019 05:02:50 -0400 (EDT) Date: Mon, 12 Aug 2019 09:10:00 -0000 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Gary Dismukes Subject: [Ada] Suppress_Initialization not respected for private subtypes Message-ID: <20190812090250.GA22598@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="HlL+5n6rz5pIUxbD" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 2620:20:4000:0:a9e:1ff:fe9b:1d1 X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00716.txt.bz2 --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 774 The compiler fails to suppress initialization on a variable of a subtype of a private type (such as System.Address) even though the subtype has aspect Suppress_Initialization. This can lead to errors on object declarations specified with Thread_Local_Storage when Initialize_Scalars is applied (as well as leading to default initialization when it shouldn't). Tested on x86_64-pc-linux-gnu, committed on trunk 2019-08-12 Gary Dismukes gcc/ada/ * sem_prag.adb (Analyze_Pragma, Pragma_Suppress_Initialization): For private types, set the Suppress_Initialization flag on the Full_View of the entity rather than the entity's base type. gcc/testsuite/ * gnat.dg/suppress_initialization2.adb, gnat.dg/suppress_initialization2.ads: New testcase. --HlL+5n6rz5pIUxbD Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="patch.diff" Content-length: 1075 --- gcc/ada/sem_prag.adb +++ gcc/ada/sem_prag.adb @@ -24169,7 +24169,7 @@ package body Sem_Prag is Error_Pragma_Arg ("argument of pragma% cannot be an incomplete type", Arg1); else - Set_Suppress_Initialization (Full_View (Base_Type (E))); + Set_Suppress_Initialization (Full_View (E)); end if; -- For first subtype, set flag on base type --- /dev/null new file mode 100644 +++ gcc/testsuite/gnat.dg/suppress_initialization2.adb @@ -0,0 +1,5 @@ +package body Suppress_Initialization2 is + + procedure Dummy is null; + +end Suppress_Initialization2; --- /dev/null new file mode 100644 +++ gcc/testsuite/gnat.dg/suppress_initialization2.ads @@ -0,0 +1,13 @@ +pragma Initialize_Scalars; + +with System; + +package Suppress_Initialization2 is + + subtype Sub_Addr is System.Address with Suppress_Initialization; + + O : Sub_Addr with Thread_Local_Storage; -- OK: no error should be reported + + procedure Dummy; + +end Suppress_Initialization2; --HlL+5n6rz5pIUxbD--