From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9344 invoked by alias); 12 Aug 2019 17:07:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9327 invoked by uid 89); 12 Aug 2019 17:07:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Aug 2019 17:07:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7207E15AB; Mon, 12 Aug 2019 10:07:54 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 77CA73F706; Mon, 12 Aug 2019 10:07:53 -0700 (PDT) Date: Mon, 12 Aug 2019 18:43:00 -0000 From: James Greenhalgh To: Wilco Dijkstra Cc: GCC Patches , Richard Earnshaw , Ramana Radhakrishnan , Richard Sandiford , nd Subject: Re: [PATCH][AArch64] Increase default function alignment Message-ID: <20190812170751.GE8207@arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00761.txt.bz2 On Fri, May 31, 2019 at 12:52:32PM +0100, Wilco Dijkstra wrote: > With -mcpu=generic the function alignment is currently 8, however almost all > supported cores prefer 16 or higher, so increase the default to 16:12. > This gives ~0.2% performance increase on SPECINT2017, while codesize is 0.12% > larger. OK. Thanks, James > ChangeLog: > 2019-05-31 Wilco Dijkstra > > * config/aarch64/aarch64.c (generic_tunings): Set function alignment to 16. > > -- > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 0023cb37bbae5afe9387840c1bb6b43586d4fac2..ed1422af6aab5e3c6eeea37ec57e69b64092a0ab 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -693,7 +693,7 @@ static const struct tune_params generic_tunings = > 4, /* memmov_cost */ > 2, /* issue_rate */ > (AARCH64_FUSE_AES_AESMC), /* fusible_ops */ > - "8", /* function_align. */ > + "16:12", /* function_align. */ > "4", /* jump_align. */ > "8", /* loop_align. */ > 2, /* int_reassoc_width. */ >