From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74978 invoked by alias); 1 Sep 2019 11:55:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74969 invoked by uid 89); 1 Sep 2019 11:55:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:569, 91572, strings X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Sep 2019 11:55:19 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 19363308123B; Sun, 1 Sep 2019 11:55:18 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-139.ams2.redhat.com [10.36.116.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A458D600C8; Sun, 1 Sep 2019 11:55:17 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x81BtFMZ019315; Sun, 1 Sep 2019 13:55:15 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x81BtEcX019314; Sun, 1 Sep 2019 13:55:14 +0200 Date: Sun, 01 Sep 2019 11:55:00 -0000 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix free_lang_data on asm stmts (PR lto/91572) Message-ID: <20190901115514.GI2120@tucnak> Reply-To: Jakub Jelinek References: <20190831063003.GE2120@tucnak> <6DE9EA1F-FDC4-4ADB-B3FB-213E2AD0D184@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6DE9EA1F-FDC4-4ADB-B3FB-213E2AD0D184@suse.de> User-Agent: Mutt/1.11.3 (2019-02-01) X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00007.txt.bz2 On Sat, Aug 31, 2019 at 03:02:18PM +0200, Richard Biener wrote: > Ok, but I wonder if we can stream the constraint strings in a simpler way - surely the type doesn't really matter? > Why are they not identifier nodes? I guess they have type because they are parsed like any other string literals during parsing and once we parse them that way, it isn't worth changing them to something else like an identifier. Would it be enough to just clear their type during free lang data or something similar? Jakub