From: Julian Brown <julian@codesourcery.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Chung-Lin Tang <chunglin_tang@mentor.com>,
Andrew Stubbs <andrew_stubbs@mentor.com>
Subject: [PATCH 1/2] [og9] Fix tree check failure with reduction localization
Date: Fri, 06 Sep 2019 12:15:00 -0000 [thread overview]
Message-ID: <20190906121525.120912-1-julian@codesourcery.com> (raw)
This patch fixes a tree-checking failure with the recently-applied patch
on the openacc-gcc-9-branch to localize reductions.
Tested with offloading to NVPTX. I will apply shortly.
Julian
ChangeLog
gcc/
* gimplify.c (gimplify_omp_workshare): Use OMP_CLAUSES, OMP_BODY
instead of OMP_TARGET_CLAUSES, OMP_TARGET_BODY.
---
gcc/ChangeLog.openacc | 5 +++++
gcc/gimplify.c | 3 +--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gcc/ChangeLog.openacc b/gcc/ChangeLog.openacc
index ddde3b8f84f..9e7893aa11e 100644
--- a/gcc/ChangeLog.openacc
+++ b/gcc/ChangeLog.openacc
@@ -1,3 +1,8 @@
+2019-09-06 Julian Brown <julian@codesourcery.com>
+
+ * gimplify.c (gimplify_omp_workshare): Use OMP_CLAUSES, OMP_BODY
+ instead of OMP_TARGET_CLAUSES, OMP_TARGET_BODY.
+
2019-09-05 Andrew Stubbs <ams@codesourcery.com>
Backport from mainline:
diff --git a/gcc/gimplify.c b/gcc/gimplify.c
index 685db1763e0..3d869447d70 100644
--- a/gcc/gimplify.c
+++ b/gcc/gimplify.c
@@ -12253,8 +12253,7 @@ gimplify_omp_workshare (tree *expr_p, gimple_seq *pre_p)
/* FIXME: Reductions are not supported in kernels regions yet. */
if (/*ort == ORT_ACC_KERNELS ||*/ ort == ORT_ACC_PARALLEL)
- localize_reductions (OMP_TARGET_CLAUSES (*expr_p),
- OMP_TARGET_BODY (*expr_p));
+ localize_reductions (OMP_CLAUSES (expr), OMP_BODY (expr));
gimple *g = gimplify_and_return_first (OMP_BODY (expr), &body);
if (gimple_code (g) == GIMPLE_BIND)
--
2.22.0
next reply other threads:[~2019-09-06 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 12:15 Julian Brown [this message]
2019-09-06 12:15 ` [PATCH 2/2] [og9] Remove duplicate SESE code in NVPTX backend Julian Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906121525.120912-1-julian@codesourcery.com \
--to=julian@codesourcery.com \
--cc=andrew_stubbs@mentor.com \
--cc=chunglin_tang@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).