public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Julian Brown <julian@codesourcery.com>
To: Chung-Lin Tang <chunglin_tang@mentor.com>
Cc: <cltang@codesourcery.com>, <gcc-patches@gcc.gnu.org>,
	Andrew Stubbs	<andrew_stubbs@mentor.com>
Subject: Re: [PATCH 2/6] [og9] OpenACC middle-end worker-partitioning support
Date: Fri, 06 Sep 2019 12:32:00 -0000	[thread overview]
Message-ID: <20190906133231.181147c1@squid.athome> (raw)
In-Reply-To: <20190905160119.29b3ec1a@squid.athome>

On Thu, 5 Sep 2019 16:01:19 +0100
Julian Brown <julian@codesourcery.com> wrote:

> On Thu, 5 Sep 2019 21:52:00 +0800
> Chung-Lin Tang <chunglin_tang@mentor.com> wrote:
> 
> > On 2019/9/5 9:45 AM, Julian Brown wrote:  
> > > Much of omp-sese.c originates from code written for NVPTX by
> > > Nathan Sidwell (adapted to work on gimple instead of RTL) --
> > > though at present, only the per-basic-block scheme is
> > > implemented, and the SESE-finding algorithm isn't yet used.    
> > 
> > Hi Julian,
> > it appears that this part broke NVPTX builds due to the duplicate
> > stuff in config/nvptx/nvptx.c and the new omp-sese.c file (e.g.
> > struct parallel). Can you fix this? (being able to factor away stuff
> > from nvptx backend into the middle-end seems a good idea in
> > general)  
> 
> Apologies -- I'll investigate.

This is now fixed by:

https://gcc.gnu.org/ml/gcc-patches/2019-09/msg00373.html

Thanks,

Julian

  reply	other threads:[~2019-09-06 12:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05  1:46 [PATCH 0/6] [og9] OpenACC worker partitioning in middle end (AMD GCN) Julian Brown
2019-09-05  1:46 ` [PATCH 2/6] [og9] OpenACC middle-end worker-partitioning support Julian Brown
2019-09-05 13:52   ` Chung-Lin Tang
2019-09-05 15:01     ` Julian Brown
2019-09-06 12:32       ` Julian Brown [this message]
2019-09-05  1:46 ` [PATCH 3/6] [og9] AMD GCN adjustments for middle-end worker partitioning Julian Brown
2019-09-05  1:46 ` [PATCH 4/6] [og9] Fix up tests for oaccdevlow pass splitting Julian Brown
2019-09-05  1:46 ` [PATCH 1/6] [og9] Target-dependent gang-private variable decl rewriting Julian Brown
2019-09-05  1:47 ` [PATCH 6/6] [og9] Enable worker partitioning for AMD GCN Julian Brown
2019-09-05  1:47 ` [PATCH 5/6] [og9] Reference reduction localization Julian Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906133231.181147c1@squid.athome \
    --to=julian@codesourcery.com \
    --cc=andrew_stubbs@mentor.com \
    --cc=chunglin_tang@mentor.com \
    --cc=cltang@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).