[Ada] Fix possible suppressed overflows in arithmetic run-time

[Ada] Fix possible suppressed overflows in arithmetic run-time

[Pierre-Marie de Rodat]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

Function Double_Divide computes the division of its parameters
(X / (Y*Z)) in a way that avoids overflows on signed integers, except in
two specific cases, when X = -2**63, abs(Y) = abs(Z) = 1 (leading to an
overflow in -To_Int(Qu)) and when X = -2**63 and Y*Z is large enough
that Qu=0 and so the remainder Ru=2**63 (leading to an overflow in
-To_Int(Ru)), for example with Y = Z = 2**32-1.

This fix avoids the overflow by applying "-" on the unsigned value
before the conversion to signed integer.

The issue cannot manifest as an overflow check failure in our runtime,
as overflow checks are suppressed by using pragma Suppress at the start
of the file. Assuming a machine implements wraparound semantics here,
the result was correct even with the suppressed overflow.

As a result, there can be no test showing the difference.

Tested on x86_64-pc-linux-gnu, committed on trunk

2019-09-17  Yannick Moy  <moy@adacore.com>

gcc/ada/

	* libgnat/s-arit64.adb (Double_Divide): Fix two possible
	overflows.

[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 606 bytes --]

--- gcc/ada/libgnat/s-arit64.adb
+++ gcc/ada/libgnat/s-arit64.adb
@@ -204,9 +204,13 @@ package body System.Arith_64 is
 
       --  Case of dividend (X) sign negative
 
+      --  We perform the unary minus operation on the unsigned value
+      --  before conversion to signed, to avoid a possible overflow for
+      --  value -2**63, both for computing R and Q.
+
       else
-         R := -To_Int (Ru);
-         Q := (if Den_Pos then -To_Int (Qu) else To_Int (Qu));
+         R := To_Int (-Ru);
+         Q := (if Den_Pos then To_Int (-Qu) else To_Int (Qu));
       end if;
    end Double_Divide;