From: Richard Henderson <richard.henderson@linaro.org>
To: gcc-patches@gcc.gnu.org
Cc: Wilco.Dijkstra@arm.com, kyrylo.tkachov@foss.arm.com,
Marcus.Shawcroft@arm.com, James.Greenhalgh@arm.com
Subject: [PATCH, AArch64 v4 0/6] LSE atomics out-of-line
Date: Wed, 18 Sep 2019 01:58:00 -0000 [thread overview]
Message-ID: <20190918015817.24408-1-richard.henderson@linaro.org> (raw)
Version 3 was back in November:
https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00062.html
Changes since v3:
* Do not swap_commutative_operands_p in aarch64_gen_compare_reg.
This is the probable cause of the bootstrap problem that Kyrill reported.
* Add unwind markers to the out-of-line functions.
* Use uxt{8,16} instead of mov in CAS functions,
in preference to including the uxt with the cmp.
* Prefer the lse case in the out-of-line fallthru (Wilco).
* Name the option -moutline-atomics (Wilco)
* Name the variable __aarch64_have_lse_atomics (Wilco);
fix the definition in lse-init.c.
* Rename the functions s/__aa64/__aarch64/ (Seemed sensible to match prev)
* Always use Pmode for the address for libcalls, fixing ilp32 (Kyrill).
Still not done is a custom calling convention during code generation,
but that can come later as an optimization.
Tested aarch64-linux on a thunder x1.
I have not run tests on any platform supporting LSE, even qemu.
r~
Richard Henderson (6):
aarch64: Extend %R for integer registers
aarch64: Implement TImode compare-and-swap
aarch64: Tidy aarch64_split_compare_and_swap
aarch64: Add out-of-line functions for LSE atomics
aarch64: Implement -moutline-atomics
TESTING: Enable -moutline-atomics by default
gcc/config/aarch64/aarch64-protos.h | 13 +
gcc/common/config/aarch64/aarch64-common.c | 6 +-
gcc/config/aarch64/aarch64.c | 204 +++++++++++----
.../atomic-comp-swap-release-acquire.c | 2 +-
.../gcc.target/aarch64/atomic-op-acq_rel.c | 2 +-
.../gcc.target/aarch64/atomic-op-acquire.c | 2 +-
.../gcc.target/aarch64/atomic-op-char.c | 2 +-
.../gcc.target/aarch64/atomic-op-consume.c | 2 +-
.../gcc.target/aarch64/atomic-op-imm.c | 2 +-
.../gcc.target/aarch64/atomic-op-int.c | 2 +-
.../gcc.target/aarch64/atomic-op-long.c | 2 +-
.../gcc.target/aarch64/atomic-op-relaxed.c | 2 +-
.../gcc.target/aarch64/atomic-op-release.c | 2 +-
.../gcc.target/aarch64/atomic-op-seq_cst.c | 2 +-
.../gcc.target/aarch64/atomic-op-short.c | 2 +-
.../aarch64/atomic_cmp_exchange_zero_reg_1.c | 2 +-
.../atomic_cmp_exchange_zero_strong_1.c | 2 +-
.../gcc.target/aarch64/sync-comp-swap.c | 2 +-
.../gcc.target/aarch64/sync-op-acquire.c | 2 +-
.../gcc.target/aarch64/sync-op-full.c | 2 +-
libgcc/config/aarch64/lse-init.c | 45 ++++
gcc/config/aarch64/aarch64.opt | 3 +
gcc/config/aarch64/atomics.md | 187 +++++++++++++-
gcc/config/aarch64/iterators.md | 3 +
gcc/doc/invoke.texi | 16 +-
libgcc/config.host | 4 +
libgcc/config/aarch64/lse.S | 235 ++++++++++++++++++
libgcc/config/aarch64/t-lse | 44 ++++
28 files changed, 709 insertions(+), 85 deletions(-)
create mode 100644 libgcc/config/aarch64/lse-init.c
create mode 100644 libgcc/config/aarch64/lse.S
create mode 100644 libgcc/config/aarch64/t-lse
--
2.17.1
next reply other threads:[~2019-09-18 1:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 1:58 Richard Henderson [this message]
2019-09-18 1:58 ` [PATCH, AArch64 v4 5/6] aarch64: Implement -moutline-atomics Richard Henderson
2019-09-18 12:58 ` Kyrill Tkachov
2019-09-18 1:58 ` [PATCH, AArch64 v4 1/6] aarch64: Extend %R for integer registers Richard Henderson
2019-09-18 1:58 ` [PATCH, AArch64 v4 3/6] aarch64: Tidy aarch64_split_compare_and_swap Richard Henderson
2019-09-18 1:58 ` [PATCH, AArch64 v4 6/6] TESTING: Enable -moutline-atomics by default Richard Henderson
2019-09-18 1:58 ` [PATCH, AArch64 v4 4/6] aarch64: Add out-of-line functions for LSE atomics Richard Henderson
2019-09-18 12:58 ` Kyrill Tkachov
2019-12-23 16:05 ` Roman Zhuykov
2019-09-18 1:58 ` [PATCH, AArch64 v4 2/6] aarch64: Implement TImode compare-and-swap Richard Henderson
2019-09-18 12:58 ` [PATCH, AArch64 v4 0/6] LSE atomics out-of-line Kyrill Tkachov
2019-09-19 14:39 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918015817.24408-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).