From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: "Martin Liška" <mliska@suse.cz>,
"GCC Patches" <gcc-patches@gcc.gnu.org>,
"Eric Botcazou" <ebotcazou@adacore.com>,
"Jakub Jelinek" <jakub@redhat.com>,
"Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>
Subject: Re: [PATCH] Come up with debug counter for store-merging.
Date: Thu, 19 Sep 2019 14:57:00 -0000 [thread overview]
Message-ID: <20190919165737.14ccca59@nbbrfq.loc> (raw)
In-Reply-To: <CAFiYyc079H74XUfSwKc54rVkd+L35uEPJa8LotY47Khxs18jOg@mail.gmail.com>
On Wed, 18 Sep 2019 11:01:59 +0200
Richard Biener <richard.guenther@gmail.com> wrote:
> On Wed, Sep 18, 2019 at 9:22 AM Martin Liška <mliska@suse.cz> wrote:
> >
> > Hi.
> >
> > After I spent quite some time with PR91758, I would like
> > to see a debug counter in store merging for the next time.
> >
> > Ready to be installed?
> OK.
> @@ -4195,7 +4196,8 @@ imm_store_chain_info::output_merged_stores ()
> bool ret = false;
> FOR_EACH_VEC_ELT (m_merged_store_groups, i, merged_store)
> {
> - if (output_merged_store (merged_store))
> + if (dbg_cnt (store_merging)
> + && output_merged_store (merged_store))
Doesn't this over-count actual merged stores? You really count the number of attempted store merges, not the actual successful stores merged. As i would expect to count the latter, i would have expected ..
> {
> unsigned int j;
> store_immediate_info *store;
dbg_cnt (store_merging) here, i.e. after the guard that determines if
the merge is benefical, no?
thanks,
next prev parent reply other threads:[~2019-09-19 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 7:22 Martin Liška
2019-09-18 9:02 ` Richard Biener
2019-09-19 14:57 ` Bernhard Reutner-Fischer [this message]
2019-09-20 7:50 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919165737.14ccca59@nbbrfq.loc \
--to=rep.dot.nop@gmail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).