From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38708 invoked by alias); 1 Oct 2019 00:24:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38648 invoked by uid 89); 1 Oct 2019 00:24:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=H*f:sk:8854D94, H*i:sk:8854D94 X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2019 00:24:37 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x910OSA3000844; Mon, 30 Sep 2019 19:24:29 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x910ORQZ000839; Mon, 30 Sep 2019 19:24:27 -0500 Date: Tue, 01 Oct 2019 00:24:00 -0000 From: Segher Boessenkool To: Ilya Leoshkevich Cc: GCC Patches , richard.guenther@gmail.com, richard.sandiford@arm.com, joseph@codesourcery.com, krebbel@linux.ibm.com, rdapp@linux.ibm.com Subject: Re: [PATCH v3 4/9] S/390: Do not use signaling vector comparisons on z13 Message-ID: <20191001002427.GR9749@gate.crashing.org> References: <20190905111019.8951-1-iii@linux.ibm.com> <20190905111019.8951-5-iii@linux.ibm.com> <20190906103423.GW9749@gate.crashing.org> <8854D94C-1B4E-406B-AFB2-23FC79658EEB@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8854D94C-1B4E-406B-AFB2-23FC79658EEB@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00002.txt.bz2 On Mon, Sep 30, 2019 at 03:36:41PM +0200, Ilya Leoshkevich wrote: > > Am 06.09.2019 um 12:34 schrieb Segher Boessenkool : > > Should you handle -fsignaling-nans here as well? > > Do you mean disabling vectorisation of LE/LT/GE/GT/LTGT when > -fsignaling-nans is in effect? This makes sense to me. I meant it sounds like you need to do *something* more than the generic code does, here. > I could do that > here, but wouldn't common code (e.g. expand_vec_cond_expr_p) be a better > place? If it can be done there, all the better, sure. Anyway, this is a separate issue, don't let me distract you :-) Segher