public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: luoxhu <luoxhu@linux.ibm.com>
Cc: Xiong Hu Luo <luoxhu@linux.vnet.ibm.com>,
	gcc-patches@gcc.gnu.org,        wschmidt@linux.ibm.com,
	hubicka@ucw.cz, mliska@suse.cz
Subject: Re: [RFC] Come up with ipa passes introduction in gccint documentation
Date: Tue, 01 Oct 2019 03:05:00 -0000	[thread overview]
Message-ID: <20191001030537.GV9749@gate.crashing.org> (raw)
In-Reply-To: <6ea75892-7462-d992-ea79-ea55d94d62a6@linux.ibm.com>

Hi!

On Mon, Sep 30, 2019 at 09:47:13AM +0800, luoxhu wrote:
> On 2019/9/30 00:17, Segher Boessenkool wrote:
> The updated output will be as below in gccint.pdf, references are valid to jump over
> (suppose should be the same in info?):

> > Did you test this with both "make info" and "make pdf" (and checked the
> > result of those of course :-) )?

The reason I ask is, there often are little mistakes (in markup for example)
that are obvious in either rendered output or in the info reader (but not
(always) in both).  Not just the content, also the way things are laid out,
and what makes a link to what, etc.

> To simplify development, the GCC pass manager differentiates between normal interprocedural
> passes see Section 9.4.2 [All regular IPA passes], page 127, small inter-procedural
> passes see Section 9.4.1 [All small IPA passes], page 127 and late inter-procedural passes see
> Section 9.4.3 [All late IPA passes], page 128. A small inter-procedural pass (SIMPLE_IPA_

It is weird to have a different order here than the order of the actual
sections, for example.

> The reason for "small" is in passes.def, it is used as 
> INSERT_PASSES_AFTER (all_small_ipa_passes).  And in cgraphunit.c:
> ipa_passes (void)
> {
> ... 
>   execute_ipa_pass_list (passes->all_small_ipa_passes);
> ...
> }
> 
> So is it OK to use small here?

I don't mind if it is "small" or "simple", but we probably should use the
same name everywhere in the manual (or, if we use both names, explain that
they are the same thing).

There are many cases where the internal name (in the GCC source code, in
pass names, etc.) is different from the external name (in the manuals, in
option names, etc.)  It is hard to decide what to use in the internals
manual then :-)  Maybe the internal name should just be changed?

> One more thing to worry about is my poor English

It's perfectly good enough that we understand what you are saying :-)

> and I am not familiar with all the
> 30+ IPA passes so not easy to extract exact explanations for them. 

Yeah...  It's a good start to just have stubs for them, I guess?  Makes
it obvious things need to be filled out, so hopefully people will :-)


Segher

  reply	other threads:[~2019-10-01  3:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29  7:56 Xiong Hu Luo
2019-09-29 16:17 ` Segher Boessenkool
2019-09-30  1:47   ` luoxhu
2019-10-01  3:05     ` Segher Boessenkool [this message]
2019-09-30  8:32 ` Martin Jambor
2019-10-08  8:52   ` [PATCH] " luoxhu
2019-10-08 20:53     ` Sandra Loosemore
2019-10-09  7:20       ` Richard Biener
2019-10-09  7:37         ` Jan Hubicka
2019-10-10 19:57           ` Sandra Loosemore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001030537.GV9749@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=luoxhu@linux.ibm.com \
    --cc=luoxhu@linux.vnet.ibm.com \
    --cc=mliska@suse.cz \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).