From: Jonathan Wakely <jwakely@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: Marek Polacek <polacek@redhat.com>,
Gerald Pfeifer <gerald@pfeifer.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Remove broken URL from libstdc++ manual
Date: Tue, 08 Oct 2019 10:42:00 -0000 [thread overview]
Message-ID: <20191008104155.GW9487@redhat.com> (raw)
In-Reply-To: <87ftk41j4l.fsf@euler.schwinge.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]
On 07/10/19 20:54 +0200, Thomas Schwinge wrote:
>Hi!
>
>On 2019-09-05T08:45:50+0100, Jonathan Wakely <jwakely@redhat.com> wrote:
>> Committed to trunk. I think I'll backport this too, so we don't keep a
>> non-working link in the docs on release branches.
>
>> commit 45a605e970ea6db474e40c02aef6b18993fea05c
>> Author: Jonathan Wakely <jwakely@redhat.com>
>> Date: Thu Sep 5 08:40:35 2019 +0100
>>
>> Remove broken URL from libstdc++ manual
>>
>> The URL for the "What Are Allocators Good For?" article has been a
>> recurring source of problems. It moved from the C/C++ Users Journal
>> website to the Dr Dobbs site after CUJ shut down, and the original
>> domain changed hands, leaving old links pointing to nefarious sites.
>>
>> Now the URL to the copy on drdobbs.com no longer works either and I
>> can't find a (legal) copy of the article online. The simplest solution
>> is to remove the URL.
>>
>> * doc/xml/manual/allocator.xml: Remove URL for bibliography entry.
>> * doc/html/*: Regenerate.
>>
>> diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml
>> index 0de1be9465a..922bc49091c 100644
>> --- a/libstdc++-v3/doc/xml/manual/allocator.xml
>> +++ b/libstdc++-v3/doc/xml/manual/allocator.xml
>> @@ -482,12 +482,9 @@
>> </biblioentry>
>>
>> <biblioentry>
>> - <title>
>> - <link xmlns:xlink="http://www.w3.org/1999/xlink"
>> - xlink:href="http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759">
>
>For what it's worth: see
><https://web.archive.org/web/*/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759>,
>and
><https://web.archive.org/web/20190622154249/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759>
>seems to be the latest revision they've got.
Good idea, thanks!
I've committed this patch to trunk.
[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1120 bytes --]
commit 9bc329fa19e859ba535e1ebbefab83b96accf4b9
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Oct 8 11:10:08 2019 +0100
Restore URL for Austern article on allocators
This reverts "Remove broken URL from libstdc++ manual" by restoring the
link, but using an archived copy from the Wayback Machine.
* doc/xml/manual/allocator.xml: Use archived copy of CUJ article.
* doc/html/*: Regenerate.
diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml
index 922bc49091c..d8a255ca213 100644
--- a/libstdc++-v3/doc/xml/manual/allocator.xml
+++ b/libstdc++-v3/doc/xml/manual/allocator.xml
@@ -483,7 +483,10 @@
<biblioentry>
<title>
+ <link xmlns:xlink="http://www.w3.org/1999/xlink"
+ xlink:href="https://web.archive.org/web/20190622154249/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759">
The Standard Librarian: What Are Allocators Good For?
+ </link>
</title>
<author><personname><firstname>Matt</firstname><surname>Austern</surname></personname></author>
prev parent reply other threads:[~2019-10-08 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 7:45 Jonathan Wakely
2019-10-07 18:55 ` Thomas Schwinge
2019-10-08 10:42 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008104155.GW9487@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=libstdc++@gcc.gnu.org \
--cc=polacek@redhat.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).