From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27371 invoked by alias); 8 Oct 2019 10:42:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27232 invoked by uid 89); 8 Oct 2019 10:42:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=online X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Oct 2019 10:42:00 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8914C7F75C; Tue, 8 Oct 2019 10:41:59 +0000 (UTC) Received: from localhost (unknown [10.33.36.125]) by smtp.corp.redhat.com (Postfix) with ESMTP id 742005C219; Tue, 8 Oct 2019 10:41:56 +0000 (UTC) Date: Tue, 08 Oct 2019 10:42:00 -0000 From: Jonathan Wakely To: Thomas Schwinge Cc: Marek Polacek , Gerald Pfeifer , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Remove broken URL from libstdc++ manual Message-ID: <20191008104155.GW9487@redhat.com> References: <20190905074550.GA8816@redhat.com> <87ftk41j4l.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="BKMA2OjimIttCqMD" Content-Disposition: inline In-Reply-To: <87ftk41j4l.fsf@euler.schwinge.homeip.net> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.12.0 (2019-05-25) X-SW-Source: 2019-10/txt/msg00526.txt.bz2 --BKMA2OjimIttCqMD Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-length: 1914 On 07/10/19 20:54 +0200, Thomas Schwinge wrote: >Hi! > >On 2019-09-05T08:45:50+0100, Jonathan Wakely wrote: >> Committed to trunk. I think I'll backport this too, so we don't keep a >> non-working link in the docs on release branches. > >> commit 45a605e970ea6db474e40c02aef6b18993fea05c >> Author: Jonathan Wakely >> Date: Thu Sep 5 08:40:35 2019 +0100 >> >> Remove broken URL from libstdc++ manual >> >> The URL for the "What Are Allocators Good For?" article has been a >> recurring source of problems. It moved from the C/C++ Users Journal >> website to the Dr Dobbs site after CUJ shut down, and the original >> domain changed hands, leaving old links pointing to nefarious sites. >> >> Now the URL to the copy on drdobbs.com no longer works either and I >> can't find a (legal) copy of the article online. The simplest solution >> is to remove the URL. >> >> * doc/xml/manual/allocator.xml: Remove URL for bibliography entry. >> * doc/html/*: Regenerate. >> >> diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml >> index 0de1be9465a..922bc49091c 100644 >> --- a/libstdc++-v3/doc/xml/manual/allocator.xml >> +++ b/libstdc++-v3/doc/xml/manual/allocator.xml >> @@ -482,12 +482,9 @@ >> >> >> >> - >> - <link xmlns:xlink="http://www.w3.org/1999/xlink" >> - xlink:href="http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759"> > >For what it's worth: see ><https://web.archive.org/web/*/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759>, >and ><https://web.archive.org/web/20190622154249/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759> >seems to be the latest revision they've got. Good idea, thanks! I've committed this patch to trunk. --BKMA2OjimIttCqMD Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" Content-length: 1120 commit 9bc329fa19e859ba535e1ebbefab83b96accf4b9 Author: Jonathan Wakely <jwakely@redhat.com> Date: Tue Oct 8 11:10:08 2019 +0100 Restore URL for Austern article on allocators This reverts "Remove broken URL from libstdc++ manual" by restoring the link, but using an archived copy from the Wayback Machine. * doc/xml/manual/allocator.xml: Use archived copy of CUJ article. * doc/html/*: Regenerate. diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml index 922bc49091c..d8a255ca213 100644 --- a/libstdc++-v3/doc/xml/manual/allocator.xml +++ b/libstdc++-v3/doc/xml/manual/allocator.xml @@ -483,7 +483,10 @@ <biblioentry> <title> + <link xmlns:xlink="http://www.w3.org/1999/xlink" + xlink:href="https://web.archive.org/web/20190622154249/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759"> The Standard Librarian: What Are Allocators Good For? + </link> MattAustern --BKMA2OjimIttCqMD--