Re: [PATCH] Come up with ipa passes introduction in gccint documentation

[Jan Hubicka <hubicka@ucw.cz>]

> On Tue, Oct 8, 2019 at 10:06 PM Sandra Loosemore
> <sandra@codesourcery.com> wrote:
> >
> > On 10/8/19 2:52 AM, luoxhu wrote:
> > > Hi,
> > >
> > > This is the formal documentation patch for IPA passes.  Thanks.
> > >
> > >
> > > None of the IPA passes are documented in passes.texi.  This patch adds
> > > a section IPA passes just before GIMPLE passes and RTL passes in
> > > Chapter 9 "Passes and Files of the Compiler".  Also, a short description
> > > for each IPA pass is provided.
> > > gccint.pdf can be produced without errors.
> > >
> > > ChangeLog:
> > >       PR middle-end/26241
> > >       * doc/lto.texi (IPA): Reference to the IPA passes.
> > >       * doc/passes.texi (Pass manager): Add node IPA passes and
> > >         description for each IPA pass.
> >
> > Thanks for submitting this documentation patch!  The content looks
> > helpful to me, but I see that it has quite a few grammar bugs (I
> > understand how hard English is even for native speakers....), plus some
> > issues like indexing, cross-referencing, use of jargon without defining
> > it, etc.  I think it would be more efficient for me to take over
> > polishing the text some more than to mark it up for you to fix, but I'd
> > like to give others a few days to comment on technical content first.
> 
> I think the contents are OK for a first try, so please go ahead polishing
> and commit.  We can then improve the content as followup (I'm making
> a note for myself to not forget).

I will add some extra info once patch is in :)

Thanks for working on this!
Honza
> 
> Thanks,
> Richard.
> 
> > -Sandra