From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63137 invoked by alias); 11 Oct 2019 15:52:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63124 invoked by uid 89); 11 Oct 2019 15:52:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:3db642e, H*MI:sk:3db642e, H*f:sk:3db642e X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Oct 2019 15:52:43 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A51ED309DEF0; Fri, 11 Oct 2019 15:52:42 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BEC760BE1; Fri, 11 Oct 2019 15:52:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x9BFqbpb014432; Fri, 11 Oct 2019 17:52:38 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x9BFqZms014431; Fri, 11 Oct 2019 17:52:35 +0200 Date: Fri, 11 Oct 2019 15:53:00 -0000 From: Jakub Jelinek To: Paolo Carlini Cc: Marek Polacek , "gcc-patches@gcc.gnu.org" , Jason Merrill Subject: Re: [C++ Patch] One more DECL_SOURCE_LOCATION Message-ID: <20191011155235.GU15914@tucnak> Reply-To: Jakub Jelinek References: <20191011133701.GM2949@redhat.com> <20191011152342.GQ2949@redhat.com> <01e20870-445a-fe9e-59ef-ef68eb25b841@oracle.com> <3db642e3-7c12-d998-e451-d18d6bd58275@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3db642e3-7c12-d998-e451-d18d6bd58275@oracle.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00854.txt.bz2 On Fri, Oct 11, 2019 at 05:34:16PM +0200, Paolo Carlini wrote: > Hi again... > > On 11/10/19 17:30, Paolo Carlini wrote: > > Oh nice, I wasn't aware of that, to be honest, probably we should audit > > the front-end for more such redundant uses. > > ... and I can confirm that we have *many*. If we agree that removing all of > them is the way to go I can do that in a follow up patch. If they just guard a pedwarn/warning/warning_at etc., that's fine, if they guard also some code that needs to compute something for the diagnostics, it might not be redundant. Jakub