From: Marek Polacek <polacek@redhat.com>
To: kamlesh kumar <kamleshbhalui@gmail.com>
Cc: gcc-patches@gcc.gnu.org, "jason@redhat.com" <jason@redhat.com>,
marxin@gcc.gnu.org
Subject: Re: [PATCH][PR91979] Incorrect mangling for non-template-argument nullptr expression
Date: Tue, 22 Oct 2019 17:23:00 -0000 [thread overview]
Message-ID: <20191022165434.GJ2922@redhat.com> (raw)
In-Reply-To: <CABKRkghgrav70yuPLpxaRXV33m30ZOq_5az0Azgy0kcP-ys8SQ@mail.gmail.com>
On Tue, Oct 22, 2019 at 10:00:19PM +0530, kamlesh kumar wrote:
> diff --git a/gcc/cp/mangle.c b/gcc/cp/mangle.c
> index a9333b8..780da9f 100644
> --- a/gcc/cp/mangle.c
> +++ b/gcc/cp/mangle.c
> @@ -3400,7 +3400,8 @@ write_template_arg_literal (const tree value)
> case INTEGER_CST:
> gcc_assert (!same_type_p (TREE_TYPE (value), boolean_type_node)
> || integer_zerop (value) || integer_onep (value));
> - write_integer_cst (value);
> + if (TREE_CODE(TREE_TYPE(value)) != NULLPTR_TYPE)
> + write_integer_cst (value);
Please use NULLPTR_TYPE_P.
Does this warrant a new -fabi-version?
Marek
next prev parent reply other threads:[~2019-10-22 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 16:39 kamlesh kumar
2019-10-22 16:54 ` kamlesh kumar
2019-10-22 17:23 ` Marek Polacek [this message]
[not found] ` <CABKRkgjaFKpsWYDMdwgkDcZZSsMyruRn5_8tVRGhp93Gx5GVUQ@mail.gmail.com>
2019-10-22 17:53 ` kamlesh kumar
2019-10-22 18:09 ` kamlesh kumar
2019-10-23 3:36 ` [[PATCH][PR91979] handle mangling of nullptr expression ] updated the fix Kamlesh Kumar
2019-10-31 18:08 ` kamlesh kumar
2019-11-01 21:14 ` Jason Merrill
2019-11-02 3:48 ` [PATCH v2] [PR91979] Updated the fix: Kamlesh Kumar
2019-11-03 8:04 ` Jason Merrill
2019-11-03 11:43 ` [PATCH v3] Updated the Fix: Kamlesh Kumar
2019-11-04 23:35 ` Jason Merrill
2020-01-12 13:31 ` Iain Sandoe
2020-01-12 14:39 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022165434.GJ2922@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=kamleshbhalui@gmail.com \
--cc=marxin@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).