From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Bill Schmidt <wschmidt@linux.ibm.com>
Subject: Re: [PATCH 3/3 V2][rs6000] vector conversion RTL pattern update for diff unit size
Date: Thu, 31 Oct 2019 18:54:00 -0000 [thread overview]
Message-ID: <20191031184859.GX28442@gate.crashing.org> (raw)
In-Reply-To: <c8e8f628-2c21-34e3-101d-56677fc31467@linux.ibm.com>
Hi!
On Thu, Oct 31, 2019 at 05:35:22PM +0800, Kewen.Lin wrote:
> >> +/* Half VMX/VSX vector (for select) */
> >> +VECTOR_MODE (FLOAT, SF, 2); /* V2SF */
> >> +VECTOR_MODE (INT, SI, 2); /* V2SI */
> >
> > Or "for internal use", in general. What happens if a user tries to create
> > something of such a mode? I hope we don't ICE :-/
>
> I did some testings, it failed (ICE) if we constructed one insn with these
> modes artificially. But I also checked the existing V8SF/V8SI/V4DF/... etc.,
> they have same issues. It looks more like a new issue to avoid that.
What does "artificially" mean? If you had to change the compiler for your
test, that doesn't count; otherwise, please file a PR.
> * config/rs6000/vsx.md (UNSPEC_VSX_CVSPSXDS, UNSPEC_VSX_CVSPUXDS): Remove.
(line too long)
Okay for trunk. Thanks!
Segher
next prev parent reply other threads:[~2019-10-31 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:39 [PATCH 0/3][rs6000] Update RTL patterns for vector conversion Kewen.Lin
2019-10-23 9:40 ` [PATCH 1/3][rs6000] Replace vsx_xvcdpsp by vsx_xvcvdpsp Kewen.Lin
2019-10-30 18:02 ` Segher Boessenkool
2019-10-23 9:42 ` [PATCH 2/3][rs6000] vector conversion RTL pattern update for same unit size Kewen.Lin
2019-10-30 18:04 ` Segher Boessenkool
2019-10-23 10:15 ` [PATCH 3/3][rs6000] vector conversion RTL pattern update for diff " Kewen.Lin
2019-10-30 19:06 ` Segher Boessenkool
2019-10-31 9:35 ` [PATCH 3/3 V2][rs6000] " Kewen.Lin
2019-10-31 18:54 ` Segher Boessenkool [this message]
2019-11-01 2:21 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031184859.GX28442@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).