From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76736 invoked by alias); 31 Oct 2019 18:49:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76727 invoked by uid 89); 31 Oct 2019 18:49:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 18:49:02 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x9VIn028012580; Thu, 31 Oct 2019 13:49:00 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x9VIn0Y9012579; Thu, 31 Oct 2019 13:49:00 -0500 Date: Thu, 31 Oct 2019 18:54:00 -0000 From: Segher Boessenkool To: "Kewen.Lin" Cc: GCC Patches , Bill Schmidt Subject: Re: [PATCH 3/3 V2][rs6000] vector conversion RTL pattern update for diff unit size Message-ID: <20191031184859.GX28442@gate.crashing.org> References: <172addbc-3aae-084b-cce4-b9c8a194821d@linux.ibm.com> <22fd6de1-dc31-a977-a803-0a2cb3f11444@linux.ibm.com> <20191030184929.GM28442@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg02263.txt.bz2 Hi! On Thu, Oct 31, 2019 at 05:35:22PM +0800, Kewen.Lin wrote: > >> +/* Half VMX/VSX vector (for select) */ > >> +VECTOR_MODE (FLOAT, SF, 2); /* V2SF */ > >> +VECTOR_MODE (INT, SI, 2); /* V2SI */ > > > > Or "for internal use", in general. What happens if a user tries to create > > something of such a mode? I hope we don't ICE :-/ > > I did some testings, it failed (ICE) if we constructed one insn with these > modes artificially. But I also checked the existing V8SF/V8SI/V4DF/... etc., > they have same issues. It looks more like a new issue to avoid that. What does "artificially" mean? If you had to change the compiler for your test, that doesn't count; otherwise, please file a PR. > * config/rs6000/vsx.md (UNSPEC_VSX_CVSPSXDS, UNSPEC_VSX_CVSPUXDS): Remove. (line too long) Okay for trunk. Thanks! Segher