public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Xiong Hu Luo <luoxhu@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org, wschmidt@linux.ibm.com
Subject: Re: [PATCH] PR92398: Fix testcase failure of pr72804.c
Date: Fri, 15 Nov 2019 10:26:00 -0000	[thread overview]
Message-ID: <20191115101711.GT16031@gate.crashing.org> (raw)
In-Reply-To: <20191115031232.130211-1-luoxhu@linux.ibm.com>

Hi!

On Thu, Nov 14, 2019 at 09:12:32PM -0600, Xiong Hu Luo wrote:
> P9LE generated instruction is not worse than P8LE.
> mtvsrdd;xxlnot;stxv vs. not;not;std;std.
> Update the test case to fix failures.

So this no longer runs it for p7, and it also doesn't run it for cpus
after p9 anymore.  Could you change it to be a test for p9 and above,
and one for before p9?  Does that work?

> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/pr72804.p8.c
> @@ -0,0 +1,16 @@
> +/* { dg-do compile { target lp64 } } */
> +/* { dg-skip-if "" { powerpc*-*-darwin* } } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
> +/* { dg-options "-O2 -mvsx -mdejagnu-cpu=power8" } */

-mvsx is implied by power8 (or power7, already).

You don't need the test for Darwin: Darwin never has VSX, already (and
if it somehow would ever get support for it, we'd want this test to run
for it).

> +/* { dg-final { scan-assembler-times "std " 0 } } */

We usually write this as scan-assembler-not, but this works just fine
as well.  Whichever you prefer.


Segher

  parent reply	other threads:[~2019-11-15 10:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15  3:29 Xiong Hu Luo
2019-11-15  6:00 ` luoxhu
2019-11-15 10:26 ` Segher Boessenkool [this message]
2019-11-18  8:21   ` [PATCH v2] " luoxhu
2019-11-19 20:22     ` Segher Boessenkool
2019-11-20  7:29       ` [PATCH v3] " luoxhu
2019-11-21 22:13         ` Segher Boessenkool
2019-11-22  6:26           ` luoxhu
2019-11-22 17:38             ` Segher Boessenkool
2019-11-25  2:29               ` luoxhu
2019-11-29 15:48                 ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115101711.GT16031@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=luoxhu@linux.ibm.com \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).