From: Jonathan Wakely <jwakely@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] __builtin_source_location ()
Date: Fri, 15 Nov 2019 12:38:00 -0000 [thread overview]
Message-ID: <20191115123522.GN17072@redhat.com> (raw)
In-Reply-To: <20191115122817.GJ4650@tucnak>
On 15/11/19 13:28 +0100, Jakub Jelinek wrote:
>On Thu, Nov 14, 2019 at 08:34:26PM +0100, Jakub Jelinek wrote:
>> The following WIP patch implements __builtin_source_location (),
>> which returns const void pointer to a std::source_location::__impl
>> struct that is required to contain __file, __function, __line and __column
>> fields, the first two with const char * type, the latter some integral type.
>
>Here is hopefully final version, with the hashing implemented,
>__file renamed to __file_name and __function to __function_name to match
>how the standard names the methods and with testsuite coverage.
The libstdc++ naming convention says the data members should be
_M_file_name, _M_line etc.
Since this is just a normal library type now, not defined by the
compiler, I think we should follow the library convention (sorry for
not noticing that sooner).
next prev parent reply other threads:[~2019-11-15 12:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 20:20 [RFC C++ " Jakub Jelinek
2019-11-14 22:25 ` Jonathan Wakely
2019-11-14 22:40 ` Jakub Jelinek
2019-11-15 12:35 ` Jonathan Wakely
2019-11-15 12:32 ` [C++ " Jakub Jelinek
2019-11-15 12:38 ` Jonathan Wakely [this message]
2019-11-15 12:55 ` Jakub Jelinek
2019-11-15 14:06 ` Jonathan Wakely
2019-11-15 14:05 ` David Malcolm
2019-11-15 14:26 ` Jakub Jelinek
2019-12-03 15:19 ` Patch ping (was Re: [C++ PATCH] __builtin_source_location ()) Jakub Jelinek
2019-12-03 20:37 ` [C++ PATCH] __builtin_source_location () Jason Merrill
2019-12-03 21:02 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115123522.GN17072@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).