From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4276 invoked by alias); 21 Nov 2019 11:40:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4264 invoked by uid 89); 21 Nov 2019 11:40:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:yddr221, H*MI:sk:yddr221, HX-Languages-Length:1852, Excess X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Nov 2019 11:40:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574336427; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wJSHvzwFRRWbEQwOv9UstTm0bZmI5kzOd6f74znNVlY=; b=KnVlju2+Nn/y2cshZLFs8kM/vLh/Zm9QxQPLTJdXQTt8baRKbgusaoMyn6jfRzat8KooWJ FIPR140JrBEmr44gjXv0gbYKy9mRuCfHChtLchb25iOW5TEeDCbeNjXeNaYK+eekCb7Fll X5H0AEVrrkTGfyFYGfRfjXYO9EaEH6A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-365-nyVecURpPsKLBHNdEuJNEg-1; Thu, 21 Nov 2019 06:40:24 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4FC9107ACC4; Thu, 21 Nov 2019 11:40:22 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3607360138; Thu, 21 Nov 2019 11:40:21 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id xALBeJve023568; Thu, 21 Nov 2019 12:40:19 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id xALBeGpV023567; Thu, 21 Nov 2019 12:40:16 +0100 Date: Thu, 21 Nov 2019 11:40:00 -0000 From: Jakub Jelinek To: Rainer Orth Cc: Wilco Dijkstra , Ian Lance Taylor , GCC Patches Subject: Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common) Message-ID: <20191121114016.GG4650@tucnak> Reply-To: Jakub Jelinek References: <20191121001845.GC4650@tucnak> <20191121005445.GD4650@tucnak> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg02085.txt.bz2 On Thu, Nov 21, 2019 at 12:03:19PM +0100, Rainer Orth wrote: > I'm seeing those, too, plus the following that are apparently only > diagnosed by Solaris ld: >=20 > +FAIL: gcc.c-torture/execute/20030913-1.c -O0 (test for excess errors) > +FAIL: gcc.c-torture/execute/20030913-1.c -O1 (test for excess errors) > +FAIL: gcc.c-torture/execute/20030913-1.c -O2 (test for excess errors) > +FAIL: gcc.c-torture/execute/20030913-1.c -O2 -flto (test for excess e= rrors) > +FAIL: gcc.c-torture/execute/20030913-1.c -O2 -flto -flto-partition=3Dn= one (test for excess errors) > +FAIL: gcc.c-torture/execute/20030913-1.c -O3 -g (test for excess erro= rs) > +FAIL: gcc.c-torture/execute/20030913-1.c -Os (test for excess errors) >=20 > Excess errors: > ld: warning: symbol 'glob' has differing types: > (file /var/tmp//ccdl_86b.o type=3DOBJT; file /lib/libc.so type=3D= FUNC); > /var/tmp//ccdl_86b.o definition taken That is arguably a weird ld feature, the libraries can contain various extensions and even if one doesn't use them, there will be a warning if chosen identifiers for variables match some function in the library. > 2019-11-21 Rainer Orth >=20 > gcc/testsuite: > * gcc.c-torture/execute/20030913-1.c: Rename glob to g. > * gcc.c-torture/execute/960218-1.c: Rename glob to gl. > * gcc.c-torture/execute/complex-6.c: Rename err to e. > * gcc.dg/torture/ssa-pta-fn-1.c: Rename glob to g. >=20 > libgomp: > * testsuite/libgomp.c/pr39591-1.c: Rename err to e. > * testsuite/libgomp.c/pr39591-2.c: Likewise. > * testsuite/libgomp.c/pr39591-3.c: Likewise. > * testsuite/libgomp.c/private-1.c: Likewise. > * testsuite/libgomp.c/task-1.c: Likewise. > * testsuite/libgomp.c/task-5.c: Renamed err to serr. That said, I can live with this, so ok for trunk. Jakub