From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74053 invoked by alias); 22 Nov 2019 14:33:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74004 invoked by uid 89); 22 Nov 2019 14:33:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 14:33:43 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id A0272288B3E; Fri, 22 Nov 2019 15:33:40 +0100 (CET) Date: Fri, 22 Nov 2019 14:48:00 -0000 From: Jan Hubicka To: Tamar Christina Cc: Feng Xue OS , Martin Jambor , "gcc-patches@gcc.gnu.org" , nd Subject: Re: Ping: [PATCH V6] Extend IPA-CP to support arithmetically-computed value-passing on by-ref argument (PR ipa/91682) Message-ID: <20191122143340.74umzvcs6eob4ukk@kam.mff.cuni.cz> References: <20191112121526.dbxmpjadlrf7vc46@kam.mff.cuni.cz> <20191112123418.huts5lnnxjaybjw6@kam.mff.cuni.cz> <20191115080931.dbyi65qmdelo5auh@kam.mff.cuni.cz> <20191115140559.hkuzjqmu6qf4atds@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2019-11/txt/msg02197.txt.bz2 > Hi Honza, > > > > > I checked update_jump_functions_after_inlining(), and found one > > suspicious place: > > > > > > for (i = 0; i < count; i++) > > > { > > > struct ipa_jump_func *dst = ipa_get_ith_jump_func (args, i); > > > if (!top) > > > { > > > ipa_set_jf_unknown (dst); > > > <<<<<<<<<<<<<<<<< we should also invalidate dst->agg.items. > > This is a good catch. In meantime a smaller testcase surfaces in > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92528 > > I am re-building Firefox with the patch I attache to the PR. > > > > Just curious how this went. Are the firefox issue sorted or is there something still to be done? Yes, Firefox is working now for me and in fact I am just in the progress of updating my branch at mozilla try servers to do some benchmarking (still have few warnings to cache etc.). There was additional interesting consequence of the patch in making inliner noticeably slower both on cc1 compilation and Firefox: propagating a lot more values made it to consider a lot more inlining contextes. So I finally pushed out patches treating non-linearities there. What remains to do is to fix the value ranges - ipa_set_jf_unknown should not invalidate them. I will try to do that soon. Honza > > Thanks, > Tamar > > > Honza