From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Jonathan Wakely <jwakely@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: Prevent all uses of DFP when unsupported (PR c/91985)
Date: Wed, 27 Nov 2019 18:01:00 -0000 [thread overview]
Message-ID: <20191127180046.GT10088@tucnak> (raw)
In-Reply-To: <alpine.DEB.2.21.1911271745260.3858@digraph.polyomino.org.uk>
On Wed, Nov 27, 2019 at 05:48:21PM +0000, Joseph Myers wrote:
> > > On 26/11/19 00:57 +0000, Joseph Myers wrote:
> > >>On Mon, 25 Nov 2019, Rainer Orth wrote:
> > >>
> > >>> and a few more, all DFP related. They used to be emitted by g++ for
> > >>> __fundamental_type_info in libsupc++/fundamental_type_info.cc and lived
> > >>> in the CXXABI_1.3.4 version. However, since Solaris *does* lack DFP
> > >>> support, that's no longer the case. I'm uncertain how best to deal with
> > >>> this, however.
> > >>
> > >>As I understand it, _GLIBCXX_USE_DECIMAL_FLOAT should already have been
> > >>undefined for this target, and so std::decimal::decimal32 etc. should not
> > >>have been usable (both the header not working without that define, and the
> > >>mode attributes in the header being rejected by the front end when DFP is
> > >>unsupported). I.e. such defines in libsupc++ would never have been usable
> > >>on this target, so I think they are something it should be safe to remove
> > >>from the ABI baseline.
> > >
> > > If it's actually impossible that any real program could have depended
> > > on those symbols, then I agree.
> >
> > this is exactly what I've got no way of telling, that's why I was asking
> > for guidance. Just removing the DFP symbols from the baselines works,
> > of course.
>
> I don't think any real program could have used those symbols; it would
> have required using __typeof (__builtin_fabsd32 (0)) or similar to access
> types that weren't normally available for those targets (and by accessing
> the types using builtins like that, you're getting a completely undefined
> function-calling ABI for them anyway).
I think various tools we use to check ABI will be unhappy about removal
of symbols. Can't we on targets that do support aliases and don't support
decimal float e.g. alias the DFP rtti symbols to void rtti symbols?
Jakub
next prev parent reply other threads:[~2019-11-27 18:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 16:47 Joseph Myers
2019-11-23 16:56 ` Jeff Law
2019-11-25 20:36 ` Rainer Orth
2019-11-26 1:05 ` Joseph Myers
2019-11-26 12:21 ` Jonathan Wakely
2019-11-27 12:18 ` Rainer Orth
2019-11-27 17:49 ` Joseph Myers
2019-11-27 18:01 ` Jakub Jelinek [this message]
2020-01-16 14:49 ` Szabolcs Nagy
2020-01-16 14:50 ` Jakub Jelinek
2019-11-26 14:02 ` Andreas Schwab
2019-11-27 21:55 ` Thomas Schwinge
2019-11-27 22:39 ` Joseph Myers
2019-11-28 14:22 ` Thomas Schwinge
2019-11-28 14:44 ` [PATCH] Fix decimal floating-point LTO streaming for offloading compilation Julian Brown
2019-11-28 15:15 ` Joseph Myers
2019-11-28 15:45 ` Segher Boessenkool
2019-11-28 18:25 ` Julian Brown
2019-11-28 19:22 ` Joseph Myers
2019-11-28 19:45 ` Richard Biener
2019-11-28 15:23 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127180046.GT10088@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=jwakely@redhat.com \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).