From: Marek Polacek <polacek@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Fix OBJ_TYPE_REF constexpr handling (PR c++/92695)
Date: Thu, 28 Nov 2019 00:13:00 -0000 [thread overview]
Message-ID: <20191127235445.GO119925@redhat.com> (raw)
In-Reply-To: <20191127234443.GF10088@tucnak>
On Thu, Nov 28, 2019 at 12:44:43AM +0100, Jakub Jelinek wrote:
> Hi!
>
> On the following testcase the constexpr evaluation of the virtual call
> fails, because what cxx_eval_constant_expression returns for
> OBJ_TYPE_REF_OBJECT is actually not ADDR_EXPR, but ADDR_EXPR wrapped in
> a NOP_EXPR.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
Looks ok. In fact, when working on constexpr dynamic_cast, I ran into a very
similar problem and also added STRIP_NOPS.
--
Marek Polacek • Red Hat, Inc. • 300 A St, Boston, MA
next prev parent reply other threads:[~2019-11-27 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 23:54 Jakub Jelinek
2019-11-28 0:13 ` Marek Polacek [this message]
2019-12-02 19:10 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127235445.GO119925@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).