From: Segher Boessenkool <segher@kernel.crashing.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Julian Brown <julian@codesourcery.com>,
gcc-patches@gcc.gnu.org,
Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [PATCH] Fix decimal floating-point LTO streaming for offloading compilation
Date: Thu, 28 Nov 2019 15:45:00 -0000 [thread overview]
Message-ID: <20191128154446.GO9491@gate.crashing.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1911281500410.22734@digraph.polyomino.org.uk>
Hi Joseph,
On Thu, Nov 28, 2019 at 03:04:05PM +0000, Joseph Myers wrote:
> On Thu, 28 Nov 2019, Julian Brown wrote:
> > Unlike e.g. the _FloatN types, when decimal floating-point types are
> > enabled, common tree nodes are created for each float type size (e.g.
> > dfloat32_type_node) and also a pointer to each type is created
> > (e.g. dfloat32_ptr_type_node). tree-streamer.c:record_common_node emits
> > these like:
>
> As far as I can tell, nothing actually uses those pointer nodes, or the
> corresponding BT_DFLOAT32_PTR etc. defined in builtin-types.def. I don't
> know if they ever were used, or if they were just added by analogy to e.g.
> float_ptr_type_node.
>
> So I'd suggest simply removing all references to those tree nodes and
> corresponding BT_*, from builtin-types.def, jit/jit-builtins.c (commented
> out), tree-core.h, tree.c, tree.h. Hopefully that will solve the
> offloading problem.
So your patch caused at least three problems, none of them completely
worked out yet, none of them trivial.
Maybe this isn't such a good idea during stage 3.
Segher
next prev parent reply other threads:[~2019-11-28 15:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 16:47 Prevent all uses of DFP when unsupported (PR c/91985) Joseph Myers
2019-11-23 16:56 ` Jeff Law
2019-11-25 20:36 ` Rainer Orth
2019-11-26 1:05 ` Joseph Myers
2019-11-26 12:21 ` Jonathan Wakely
2019-11-27 12:18 ` Rainer Orth
2019-11-27 17:49 ` Joseph Myers
2019-11-27 18:01 ` Jakub Jelinek
2020-01-16 14:49 ` Szabolcs Nagy
2020-01-16 14:50 ` Jakub Jelinek
2019-11-26 14:02 ` Andreas Schwab
2019-11-27 21:55 ` Thomas Schwinge
2019-11-27 22:39 ` Joseph Myers
2019-11-28 14:22 ` Thomas Schwinge
2019-11-28 14:44 ` [PATCH] Fix decimal floating-point LTO streaming for offloading compilation Julian Brown
2019-11-28 15:15 ` Joseph Myers
2019-11-28 15:45 ` Segher Boessenkool [this message]
2019-11-28 18:25 ` Julian Brown
2019-11-28 19:22 ` Joseph Myers
2019-11-28 19:45 ` Richard Biener
2019-11-28 15:23 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128154446.GO9491@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=julian@codesourcery.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).