From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111545 invoked by alias); 29 Nov 2019 09:30:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 111412 invoked by uid 89); 29 Nov 2019 09:30:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.1 spammy=c-cppbuiltin.c, feat-cxx2a.C, UD:feat-cxx2a.C, featcxx2aC X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Nov 2019 09:30:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575019828; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=01bi6PajTJ3NQK11F9J5VEAC+CqzffN+qpfdQHhw2i8=; b=cTvAkVxl4XmAfVgeACbMzP7HGyTejY/iHPQI/c05voBKVp2XEWAOYQa9amxCQ6IlZ0A7Zo TTG+RcGtTUpo52r7SERE6/vc/a0lIIpezGYw0AOWp8Nf3OpsJJRBxlWx7qTbKb0OLSXen6 gf0zGsFX5BfPudzpq054dDo3QQqiWZc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-B6dDlyrvNr6AT1dlxWzOfg-1; Fri, 29 Nov 2019 04:30:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2467D184CAA4 for ; Fri, 29 Nov 2019 09:30:24 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-117-59.ams2.redhat.com [10.36.117.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A84366091F; Fri, 29 Nov 2019 09:30:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id xAT9UE4B021193; Fri, 29 Nov 2019 10:30:14 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id xAT9UDMw021192; Fri, 29 Nov 2019 10:30:13 +0100 Date: Fri, 29 Nov 2019 10:10:00 -0000 From: Jakub Jelinek To: Jason Merrill Cc: gcc-patches@gcc.gnu.org Subject: [C++ PATCH] (temporarily) undefine __cpp_consteval Message-ID: <20191129093013.GI10088@tucnak> Reply-To: Jakub Jelinek MIME-Version: 1.0 User-Agent: Mutt/1.11.3 (2019-02-01) X-Mimecast-Spam-Score: 0 Content-Type: multipart/mixed; boundary="WYTEVAkct0FjGQmd" Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg02616.txt.bz2 --WYTEVAkct0FjGQmd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2036 Hi! When submitting the P1902R1 patch for missing feature macros, I completely forgot that we can't claim consteval support, because we have the /* FIXME: For now. */ if (virtualp && (inlinep & 8) !=3D 0) { sorry_at (DECL_SOURCE_LOCATION (decl), "% % method %qD not supported yet", decl); inlinep &=3D ~8; } limitation in consteval support. I've tried to make some progress on it in PR88335, but am stuck, so this patch instead comments out this and updates cxx-status.html to explain the partial support. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and wwwdocs? 2019-11-29 Jakub Jelinek * c-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for now. * g++.dg/cpp2a/feat-cxx2a.C: Don't test __cpp_consteval for now. --- gcc/c-family/c-cppbuiltin.c.jj 2019-11-28 09:02:23.705869433 +0100 +++ gcc/c-family/c-cppbuiltin.c 2019-11-28 18:59:20.407918255 +0100 @@ -999,7 +999,7 @@ c_cpp_builtins (cpp_reader *pfile) cpp_define (pfile, "__cpp_designated_initializers=3D201707L"); cpp_define (pfile, "__cpp_constexpr_in_decltype=3D201711L"); cpp_define (pfile, "__cpp_conditional_explicit=3D201806L"); - cpp_define (pfile, "__cpp_consteval=3D201811L"); + /* cpp_define (pfile, "__cpp_consteval=3D201811L"); */ cpp_define (pfile, "__cpp_constinit=3D201907L"); cpp_define (pfile, "__cpp_deduction_guides=3D201907L"); cpp_define (pfile, "__cpp_nontype_template_parameter_class=3D201806L"); --- gcc/testsuite/g++.dg/cpp2a/feat-cxx2a.C.jj 2019-11-28 09:02:25.33184445= 3 +0100 +++ gcc/testsuite/g++.dg/cpp2a/feat-cxx2a.C 2019-11-28 19:00:59.459400136 += 0100 @@ -520,11 +520,13 @@ # error "__cpp_constexpr_in_decltype !=3D 201711" #endif =20 +/* Not supported fully yet: #ifndef __cpp_consteval # error "__cpp_consteval" #elif __cpp_consteval !=3D 201811 # error "__cpp_consteval !=3D 201811" #endif +*/ =20 #ifndef __cpp_concepts # error "__cpp_concepts" Jakub --WYTEVAkct0FjGQmd Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="cxx-status.patch" Content-Transfer-Encoding: quoted-printable Content-length: 638 diff --git a/htdocs/projects/cxx-status.html b/htdocs/projects/cxx-status.h= tml index c6ff78e1..c8655a17 100644 --- a/htdocs/projects/cxx-status.html +++ b/htdocs/projects/cxx-status.html @@ -288,7 +288,8 @@ Immediate functions (consteval) P1073R3 - 10 + 10 + (partial, no consteval virtual support) __cpp_consteval >=3D 201811 --WYTEVAkct0FjGQmd--