From: Michael Meissner <meissner@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH], V7, #2 of 7, Use PLI to load up 32-bit SImode constants
Date: Tue, 03 Dec 2019 17:57:00 -0000 [thread overview]
Message-ID: <20191203175724.GA12739@ibm-tinman.the-meissners.org> (raw)
In-Reply-To: <20191126004949.GZ9491@gate.crashing.org>
On Mon, Nov 25, 2019 at 06:49:49PM -0600, Segher Boessenkool wrote:
> On Mon, Nov 25, 2019 at 05:17:08PM -0500, Michael Meissner wrote:
> > On Fri, Nov 22, 2019 at 06:20:52PM -0600, Segher Boessenkool wrote:
> > > > (define_split
> > > > [(set (match_operand:SI 0 "gpc_reg_operand")
> > > > (match_operand:SI 1 "const_int_operand"))]
> > > > "(unsigned HOST_WIDE_INT) (INTVAL (operands[1]) + 0x8000) >= 0x10000
> > > > - && (INTVAL (operands[1]) & 0xffff) != 0"
> > > > + && (INTVAL (operands[1]) & 0xffff) != 0 && !TARGET_PREFIXED_ADDR"
> > > > [(set (match_dup 0)
> > > > (match_dup 2))
> > > > (set (match_dup 0)
> > >
> > > Please use num_insns_constant, instead (and fix num_insns_constant_gpr
> > > so it knows about SIGNED_34BIT).
> >
> > The previous patch V6 #1 already had the modification for
> > num_insns_constant_gpr.
>
> It's not in trunk yet?
Sorry, the USA Thanksgiving holiday got in the way.
No, the change for num_insns_constant_gpr could not go in until the support for
PLI went in (patch V6 #1).
So for patches V6 #1-3, I believe you approved #1 (movdi) and #3 (addi3/addsi3)
after the changes but not #2 (movsi). I haven't yet applied the specific bits
of #1 or #3 after doing the reformating patch. Are the bits for #2 ok with the
above change to use num_insns_constant_gpr. Or did you want to see the 3
patches once again after the reformating.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.ibm.com, phone: +1 (978) 899-4797
next prev parent reply other threads:[~2019-12-03 17:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 22:31 PowerPC V7 future machine patches Michael Meissner
2019-11-14 22:42 ` [PATCH] V7, #1 of 7, Use PLI to load up 34-bit DImode constants Michael Meissner
2019-11-23 0:20 ` Segher Boessenkool
2019-11-25 22:13 ` Michael Meissner
2019-11-25 23:08 ` Segher Boessenkool
2019-11-14 22:44 ` [PATCH], V7, #2 of 7, Use PLI to load up 32-bit SImode constants Michael Meissner
2019-11-23 0:32 ` Segher Boessenkool
2019-11-25 22:18 ` Michael Meissner
2019-11-26 0:55 ` Segher Boessenkool
2019-12-03 17:57 ` Michael Meissner [this message]
2019-12-03 19:26 ` Segher Boessenkool
2019-11-14 22:51 ` [PATCH], V7, #3 of 7, Use PADDI for 34-bit immediate adds Michael Meissner
2019-11-23 0:52 ` Segher Boessenkool
2019-11-25 22:47 ` Michael Meissner
2019-11-26 0:55 ` Segher Boessenkool
2019-11-14 22:56 ` [PATCH] V7, #4 of 7, Add explicit (0),1 to @pcrel references Michael Meissner
2019-11-23 1:03 ` Segher Boessenkool
2019-11-25 23:00 ` Michael Meissner
2019-11-26 1:42 ` Segher Boessenkool
2019-11-26 5:57 ` Alan Modra
2019-11-14 23:09 ` [PATCH], V7, #5 of 7, Add more effective targets for the 'future' system to target-supports Michael Meissner
2019-11-23 6:54 ` Segher Boessenkool
2019-12-03 18:12 ` Michael Meissner
2019-12-03 19:52 ` Segher Boessenkool
2019-11-14 23:14 ` [PATCH], V7, #6 of 7, Fix issues with vector extract and prefixed instructions Michael Meissner
2019-11-26 19:27 ` Segher Boessenkool
2019-12-03 18:20 ` Michael Meissner
2019-12-03 20:37 ` Segher Boessenkool
2019-11-14 23:46 ` [PATCH], V7, #7 of 7, Turn on -mpcrel for Linux 64-bit, but not for other targets Michael Meissner
2019-11-26 23:43 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203175724.GA12739@ibm-tinman.the-meissners.org \
--to=meissner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).