From: Segher Boessenkool <segher@kernel.crashing.org>
To: Martin Sebor <msebor@gmail.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org,
fortran@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>,
Tobias Burnus <tobias@codesourcery.com>,
Michael Meissner <meissner@linux.ibm.com>
Subject: Re: [RFC] Characters per line: from punch card (80) to line printer (132)
Date: Thu, 05 Dec 2019 20:32:00 -0000 [thread overview]
Message-ID: <20191205203203.GL3152@gate.crashing.org> (raw)
In-Reply-To: <ec7f5c74-af68-9862-56a8-464aa6fa1036@gmail.com>
On Thu, Dec 05, 2019 at 11:54:04AM -0700, Martin Sebor wrote:
> >> if (present)
> >> ptr
> >> = gfc_build_conditional_assign_expr (block,
> >> present,
> >> ptr, nullarg);
>
> The snippet of code above looks like it might be the symptom
> of another common problem: deeply nested conditionals, case
> statements, or loops in very large functions. Those usually
> make it much harder to follow code than local variables or
> expressions that are broken up to fit the width limit.
> Shorter functions typically also means fewer local variables.
Yes, and you only get problems that you do not know which var is which,
or you do not know what value it is set to because it was set some 2800
(or 40 or whatever) lines ago, in WAY too long functions.
All those problems do not exist in well-factored code. The point is not
to have short routines: the point is to not have too much (external)
complexity per routine. A routine should ideally only do one thing, and
its name should describe what it does.
Segher
next prev parent reply other threads:[~2019-12-05 20:32 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <75222f0b-b55d-dcd9-b4f4-8e218675e8d7@mentor.com>
2019-07-12 11:35 ` [PATCH 0/5, OpenACC] Add support for Fortran optional arguments in OpenACC Kwok Cheung Yeung
2019-07-12 11:36 ` [PATCH 1/5, OpenACC] Allow NULL as an argument to OpenACC 2.6 directives Kwok Cheung Yeung
2019-11-29 14:42 ` [PR92726] OpenACC: 'NULL'-in -> no-op, and/or 'NULL'-out (was: [PATCH 1/5, OpenACC] Allow NULL as an argument to OpenACC 2.6 directives) Thomas Schwinge
2019-11-20 13:11 ` [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments Tobias Burnus
2019-11-29 12:17 ` Tobias Burnus
2019-12-05 15:16 ` Jakub Jelinek
2019-12-05 15:47 ` [RFC] Characters per line: from punch card (80) to line printer (132) (was: [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments) Thomas Schwinge
2019-12-05 16:04 ` Jakub Jelinek
2019-12-05 20:21 ` Segher Boessenkool
2019-12-05 16:17 ` Joseph Myers
2019-12-05 16:24 ` Paul Koning
2019-12-05 16:40 ` Jeff Law
2019-12-05 16:55 ` [RFC] Characters per line: from punch card (80) to line printer (132) Florian Weimer
2019-12-05 17:55 ` Andrew Stubbs
2019-12-05 18:12 ` Eric Gallager
2019-12-05 18:22 ` Robin Curtis
2019-12-05 19:16 ` James Secan
2019-12-06 9:22 ` Andrew Stubbs
2019-12-05 16:44 ` [RFC] Characters per line: from punch card (80) to line printer (132) (was: [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments) Michael Matz
2019-12-05 17:03 ` Jonathan Wakely
2019-12-05 18:07 ` Marek Polacek
2019-12-05 20:06 ` Segher Boessenkool
2019-12-05 20:38 ` Marek Polacek
2019-12-05 22:02 ` Segher Boessenkool
2019-12-05 20:56 ` Jonathan Wakely
2019-12-05 22:19 ` Segher Boessenkool
2019-12-05 22:34 ` Jonathan Wakely
2019-12-05 22:37 ` Jonathan Wakely
2019-12-05 23:02 ` Segher Boessenkool
2019-12-05 17:29 ` N.M. Maclaren
2019-12-05 20:12 ` Segher Boessenkool
2019-12-05 20:41 ` Jason Merrill
2019-12-05 18:54 ` [RFC] Characters per line: from punch card (80) to line printer (132) Martin Sebor
2019-12-05 20:32 ` Segher Boessenkool [this message]
2019-12-07 14:49 ` [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments Thomas Schwinge
2019-12-11 10:52 ` Tobias Burnus
2019-12-10 17:54 ` [Patch, Fortran] OpenMP/OpenACC – fix more issues with OPTIONAL Tobias Burnus
2019-12-16 9:25 ` *ping* " Tobias Burnus
2019-12-29 23:46 ` *ping**2 " Tobias Burnus
2019-12-30 4:33 ` Jerry
2020-01-03 11:29 ` Jakub Jelinek
2020-01-08 8:33 ` Thomas Schwinge
2020-01-08 8:55 ` Tobias Burnus
2020-04-29 10:00 ` Thomas Schwinge
2020-04-29 14:01 ` Tobias Burnus
2020-04-30 6:24 ` Richard Biener
2020-04-30 7:17 ` Jakub Jelinek
2020-05-05 9:08 ` Tobias Burnus
2020-06-17 22:22 ` Thomas Schwinge
2019-12-02 16:59 ` [PR92726] OpenACC: 'NULL'-in -> no-op, and/or 'NULL'-out Tobias Burnus
2019-07-12 11:37 ` [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause Kwok Cheung Yeung
2019-07-12 11:42 ` Jakub Jelinek
2019-07-17 18:08 ` Kwok Cheung Yeung
2019-07-17 20:49 ` Tobias Burnus
2019-07-18 9:30 ` Tobias Burnus
2019-07-18 11:45 ` Kwok Cheung Yeung
2019-07-29 21:01 ` Kwok Cheung Yeung
2019-07-31 12:54 ` Jakub Jelinek
2019-10-07 9:26 ` Thomas Schwinge
2019-10-07 13:16 ` Kwok Cheung Yeung
2019-07-12 11:39 ` [PATCH 3/5, OpenACC] Add support for allocatable arrays as optional arguments Kwok Cheung Yeung
2019-07-12 11:39 ` [PATCH 4/5, OpenACC] Allow optional arguments to be used in the use_device OpenACC clause Kwok Cheung Yeung
2019-07-29 22:42 ` Kwok Cheung Yeung
2019-07-31 13:13 ` Jakub Jelinek
2019-07-12 11:41 ` [PATCH 5/5, OpenACC] Add tests for Fortran optional arguments in OpenACC 2.6 Kwok Cheung Yeung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205203203.GL3152@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=meissner@linux.ibm.com \
--cc=msebor@gmail.com \
--cc=thomas@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).