public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Fix flag_toplevel_reorder wrt optimize attribute
@ 2019-12-08 13:53 Jan Hubicka
  0 siblings, 0 replies; only message in thread
From: Jan Hubicka @ 2019-12-08 13:53 UTC (permalink / raw)
  To: gcc-patches, mliska

Hi,
this is (very likely partial) fix for PR92860 where optimize attribute
incorrectly rewrites flag_toplevel_reorder which we handle as global
flag.  In fact we support per-symbol toplevel reordering for a while
so we only need to add the annotation. However we need to inspect all
other flags implied by optimize that they have Optimization attribute on
them.

Also i think this should be backoported to release branches, but it
breaks LTO streaming compaibility.

Bootstrapped/regtested x86_64-linux, comitted.

	PR tree-optimization/92860
	* common.opt (fprofile-reorder-functions, ftoplevel-reorder): Add
	Optimization flag.
Index: common.opt
===================================================================
--- common.opt	(revision 279076)
+++ common.opt	(working copy)
@@ -2181,7 +2181,7 @@ Common Report Var(profile_report)
 Report on consistency of profile.
 
 fprofile-reorder-functions
-Common Report Var(flag_profile_reorder_functions)
+Common Report Var(flag_profile_reorder_functions) Optimization
 Enable function reordering that improves code placement.
 
 fpatchable-function-entry=
@@ -2586,7 +2586,7 @@ EnumValue
 Enum(tls_model) String(local-exec) Value(TLS_MODEL_LOCAL_EXEC)
 
 ftoplevel-reorder
-Common Report Var(flag_toplevel_reorder) Init(2)
+Common Report Var(flag_toplevel_reorder) Init(2) Optimization
 Reorder top level functions, variables, and asms.
 
 ftracer

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-12-08 13:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-08 13:53 Fix flag_toplevel_reorder wrt optimize attribute Jan Hubicka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).