From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4805 invoked by alias); 18 Dec 2019 14:16:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1686 invoked by uid 89); 18 Dec 2019 14:16:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=became, replying, H*Ad:D*googlemail.com, dfp X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 14:16:02 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id xBIEFxtI006418; Wed, 18 Dec 2019 08:15:59 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id xBIEFufu006401; Wed, 18 Dec 2019 08:15:56 -0600 Date: Wed, 18 Dec 2019 14:19:00 -0000 From: Segher Boessenkool To: Peter Bergner Cc: GCC Patches , David Edelsohn , Iain Sandoe Subject: Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins Message-ID: <20191218141556.GX3152@gate.crashing.org> References: <6129bc8a-18f3-3c25-22c0-f26e4358c5b3@linux.ibm.com> <20191204191641.GA3152@gate.crashing.org> <4e90e982-6153-0009-c557-f963f41a0427@linux.ibm.com> <20191204205057.GC3152@gate.crashing.org> <49f70c63-5733-d2a5-6433-807c2663826e@linux.ibm.com> <20191204230331.GG3152@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01308.txt.bz2 (Whoops, I missed replying t this one. Sorry.) On Tue, Dec 10, 2019 at 12:27:11PM -0600, Peter Bergner wrote: > On 12/4/19 5:03 PM, Segher Boessenkool wrote: > > On Wed, Dec 04, 2019 at 03:53:30PM -0600, Peter Bergner wrote: > >> Right. I'll come up with a patch and hopefully Iain and David can test > >> on Darwin and AIX and I can test on Linux with --enable-decimal-float > >> and --disable-decimal-float. That should cover the major subtargets and > >> if it works there, I'd expect it to work on the minor subtargets too. > > Ok, how about the patch below? If Iain and David could test this on Darwin > and AIX respectively, that would be great. I'm currently testing this on > powerpc64le-linux, with and without --disable-decimal-float. > > The pr92661.c test case is the DFP test case you wanted added to make sure > we do not ICE, even when DFP is disabled. The dfp-[dt]d*.c changes are > due to me seeing them being run (and FAILing) on my --disable-decimal-float > runs. Clearly, they shouldn't be run when DFP is disabled. > > All of the powerpc/dfp/* tests had powerpc*-*-* target tests, but that is > covered by the dfp.exp target tests, so I removed them along with the > now unneeded dg-skip-if AIX tests. If dg-do compile is the default, do > we want to just remove that whole line? > > How is this looking? > --- gcc/testsuite/gcc.target/powerpc/pr92661.c (nonexistent) > +++ gcc/testsuite/gcc.target/powerpc/pr92661.c (working copy) > @@ -0,0 +1,19 @@ > +/* { dg-do compile { target { powerpc*-*-* } } } */ > +/* { dg-options "-w -O2 -mdejagnu-cpu=power9" } */ You don't need that target clause in gcc.target/powerpc (and dg-do compile is the default, but having it explicit is also fine of course). > --- gcc/testsuite/gcc.target/powerpc/dfp-dd.c (revision 278980) > +++ gcc/testsuite/gcc.target/powerpc/dfp-dd.c (working copy) > @@ -1,6 +1,7 @@ > /* Test generation of DFP instructions for POWER6. */ > /* Origin: Janis Johnson */ > -/* { dg-do compile { target { powerpc*-*-linux* && powerpc_fprs } } } */ > +/* { dg-do compile { target { powerpc*-*-linux* } } } */ > +/* { dg-require-effective-target dfp_hw } */ You can remove powerpc_fprs now because it became redundant? Cool. But dfp_hw is the wrong conditions for a dg-do compile test. Nice cleanups! Please fix that dfp_hw thing, and then, okay for trunk, Thanks! Segher