From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH] V11 patch #2 of 15, Use prefixed load for vector extract with large offset
Date: Sun, 22 Dec 2019 17:24:00 -0000 [thread overview]
Message-ID: <20191222171009.GB4505@gate.crashing.org> (raw)
In-Reply-To: <20191220233832.GB28993@ibm-toto.the-meissners.org>
Hi!
On Fri, Dec 20, 2019 at 06:38:32PM -0500, Michael Meissner wrote:
> --- gcc/config/rs6000/rs6000.c (revision 279553)
> +++ gcc/config/rs6000/rs6000.c (working copy)
> @@ -6792,9 +6792,17 @@ rs6000_adjust_vec_address (rtx scalar_re
> HOST_WIDE_INT offset = INTVAL (op1) + INTVAL (element_offset);
> rtx offset_rtx = GEN_INT (offset);
>
> - if (IN_RANGE (offset, -32768, 32767)
> + /* 16-bit offset. */
> + if (SIGNED_INTEGER_16BIT_P (offset)
> && (scalar_size < 8 || (offset & 0x3) == 0))
> new_addr = gen_rtx_PLUS (Pmode, op0, offset_rtx);
We probably should have a macro for this, hrm. The
reg_or_aligned_short_operand predicate is the closest we have right now.
> + /* 34-bit offset if we have prefixed addresses. */
> + else if (TARGET_PREFIXED_ADDR && SIGNED_INTEGER_34BIT_P (offset))
> + new_addr = gen_rtx_PLUS (Pmode, op0, offset_rtx);
This is cint34_operand.
And maybe we want both in one, for convenience?
(Something for the future of course, not this patch).
> + /* Offset overflowed, move offset to the temporary (which will likely
> + be split), and do X-FORM addressing. */
> else
> {
The comment should go here, instead (after the {).
> + /* Make sure we don't overwrite the temporary if the element being
> + extracted is variable, and we've put the offset into base_tmp
> + previously. */
> + else if (rtx_equal_p (base_tmp, element_offset))
> + emit_insn (gen_add2_insn (base_tmp, op1));
Register equality (in the same mode, as we have here) is just "==". Is
that what we need here, or should it be reg_mentioned_p?
This whole function is too complex (and it writes TARGET_POWERPC64 where
it needs TARGET_64BIT, for example).
The patch is okay for trunk (with the comment moved, and the rtx_equal_p
fixed). Thanks!
Segher
next prev parent reply other threads:[~2019-12-22 17:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 23:15 PowerPC -mcpu=future patches, V11 Michael Meissner
2019-12-20 23:28 ` [PATCH] V11 patch #1 of 15, Fix bug in vec_extract Michael Meissner
2019-12-22 14:06 ` Segher Boessenkool
2019-12-20 23:47 ` [PATCH] V11 patch #2 of 15, Use prefixed load for vector extract with large offset Michael Meissner
2019-12-22 17:24 ` Segher Boessenkool [this message]
2020-01-07 1:41 ` [PATCH, committed] " Michael Meissner
2019-12-20 23:49 ` [PATCH] V11 patch #3 of 15, Use 'Q' constraint for variable vector extract from memory Michael Meissner
2019-12-22 17:49 ` Segher Boessenkool
2020-01-07 1:43 ` [PATCH, committed] " Michael Meissner
2019-12-20 23:56 ` [PATCH] V11 patch #4 of 15, Update 'Q' constraint documentation Michael Meissner
2019-12-22 20:02 ` Segher Boessenkool
2020-01-07 1:45 ` [PATCH, committed] " Michael Meissner
2019-12-21 0:00 ` [PATCH] V11 patch #5 of 15, Optimize vec_extract of a vector in memory with a PC-relative address Michael Meissner
2019-12-25 6:41 ` Segher Boessenkool
2020-01-06 20:55 ` Michael Meissner
2020-01-06 21:01 ` Michael Meissner
2020-01-07 1:48 ` [PATCH, committed] " Michael Meissner
2019-12-21 0:03 ` [PATCH] V11 patch #6 of 15, Make -mpcrel the default for -mcpu=future on Linux 64-bit Michael Meissner
2019-12-21 0:06 ` [PATCH] V11 patch #7 of 15, Add new target_supports cases for -mcpu=future tests Michael Meissner
2019-12-21 0:11 ` [PATCH] V11 patch #8 of 15, Add new tests for using PADDI and PLI with -mcpu=future Michael Meissner
2019-12-21 0:12 ` [PATCH] V11 patch #9 of 15, Add test to validate generating prefixed memory when the offset is invalid for DS/DQ insns Michael Meissner
2019-12-21 0:22 ` [PATCH] V11 patch #10 of 15, Make sure we don't generate pre-modify prefixed insns with -mcpu=future Michael Meissner
2019-12-21 0:25 ` [PATCH] V11 patch #11 of 15, Add new tests for generating prefixed loads/stores on -mcpu=future with large offsets Michael Meissner
2019-12-21 0:25 ` [PATCH] V11 patch #12 of 15, Add new PC-relative tests for -mcpu=future Michael Meissner
2019-12-21 0:33 ` [PATCH] V11 patch #13 of 15, Add test for -mcpu=future -fstack-protect-strong with large stacks Michael Meissner
2019-12-21 1:23 ` [PATCH] V11 patch #14 of 15, Add tests for vec_extract from memory with PC-relative addrss Michael Meissner
2019-12-21 1:25 ` [PATCH] V11 patch #15 of 15, Add tests for -mcpu=future vec_extract from memory with a large offset Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191222171009.GB4505@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).