From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53124 invoked by alias); 22 Dec 2019 17:49:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53094 invoked by uid 89); 22 Dec 2019 17:49:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=mdtet, That's, UD:tet, UD:md.tet X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Dec 2019 17:49:22 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id xBMHnKuu029119; Sun, 22 Dec 2019 11:49:20 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id xBMHnJTB029118; Sun, 22 Dec 2019 11:49:19 -0600 Date: Sun, 22 Dec 2019 20:02:00 -0000 From: Segher Boessenkool To: Michael Meissner , gcc-patches@gcc.gnu.org, David Edelsohn Subject: Re: [PATCH] V11 patch #4 of 15, Update 'Q' constraint documentation. Message-ID: <20191222174919.GD4505@gate.crashing.org> References: <20191220231507.GA18386@ibm-toto.the-meissners.org> <20191220234930.GD28993@ibm-toto.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191220234930.GD28993@ibm-toto.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01536.txt.bz2 On Fri, Dec 20, 2019 at 06:49:30PM -0500, Michael Meissner wrote: > In doing V11 patch #3, I noticed that the documentation for the 'Q' was > misleading. It originally was used just for lswi/stswi, which can access up to the first 32 bytes of storage pointed to by the register. But yes, the current comment is confusing. > * config/rs6000/constraints.md (Q constraint): Update > documentation. > * doc/md.tet (PowerPC constraints): Update 'Q' constraint > documentation. "md.tet"? That's an interesting typo :-) > (define_memory_constraint "Q" > - "Memory operand that is an offset from a register (it is usually better > -to use @samp{m} or @samp{es} in @code{asm} statements)" > + "A memory operand whose address which uses a single register with no offset." Arm has (define_memory_constraint "Q" "@internal An address that is a single base register." (and (match_code "mem") (match_test "REG_P (XEXP (op, 0))"))) which is more correct for us (the register cannot be r0!) But it is not an address. Maybe "A memory operand addressed by just a base register." ? Okay for trunk like that. Thanks! Segher