From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Fix PR 44960, accepts invalid reference on function
Date: Fri, 17 Jan 2020 07:03:00 -0000 [thread overview]
Message-ID: <20200117034959.GA76405@troutmask.apl.washington.edu> (raw)
In-Reply-To: <c2e6c9d8-2074-de56-9da3-0d4fa3207714@netcologne.de>
On Thu, Jan 16, 2020 at 11:34:43PM +0100, Thomas Koenig wrote:
> diff --git a/gcc/testsuite/gfortran.dg/function_reference_1.f90 b/gcc/testsuite/gfortran.dg/function_reference_1.f90
> new file mode 100644
> index 00000000000..78c92a6f20d
> --- /dev/null
> +++ b/gcc/testsuite/gfortran.dg/function_reference_1.f90
> @@ -0,0 +1,11 @@
> +! { dg-do compile }
> +! PR 44960 - this was erroneusly accepted.
> +! Original test case by Daniel Franke.
> +
> +type t
> + integer :: a
> +end type t
> +type(t) :: foo
> +print *, foo(1)%a ! { dg-error "Function call can not contain a reference" }
> +end
> +
I do not understand this error message, and find it to be confusing.
foo(1)%a looks like an invalid array reference. That is, foo is scalar
and foo(1) is an array element.
PS: s/can not/cannot
--
Steve
next prev parent reply other threads:[~2020-01-17 3:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 23:00 Thomas Koenig
2020-01-17 7:03 ` Steve Kargl [this message]
2020-01-17 8:43 ` Tobias Burnus
2020-01-17 16:26 ` Steve Kargl
2020-01-17 23:14 ` Thomas Koenig
2020-01-18 0:06 ` Steve Kargl
2020-01-18 12:09 ` Tobias Burnus
2020-01-18 12:55 ` Thomas Koenig
2020-01-19 1:58 ` Thomas Koenig
2020-01-19 2:17 ` Tobias Burnus
2020-01-17 8:31 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117034959.GA76405@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).