From: Jan Hubicka <hubicka@ucw.cz>
To: David Malcolm <dmalcolm@redhat.com>
Cc: "Martin Liška" <mliska@suse.cz>, luoxhu <luoxhu@linux.ibm.com>,
"Christophe Lyon" <christophe.lyon@linaro.org>,
"Segher Boessenkool" <segher@kernel.crashing.org>,
"Bill Schmidt" <wschmidt@linux.ibm.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] ipa-profile.c: reset call_sums state within ipa-profile.c (v2; PR 93315)
Date: Tue, 21 Jan 2020 15:18:00 -0000 [thread overview]
Message-ID: <20200121151031.GB4245@kam.mff.cuni.cz> (raw)
In-Reply-To: <20200121135640.17844-1-dmalcolm@redhat.com>
>
> If we do, then, if I understand correctly, this would only affect
> someone who tried to use libgccjit to generate .o files with -flto,
> repeatedly, within a single process. I don't know of anyone doing
> that, and if that's broken, that would be a separate, pre-existing,
> bug, I think.
Yes, i think we can play with that incrementally especially if someone
tries to use -flto with JIT setup (which by itself looks like bit of
overkill but perhaps things like offloading or so could make this
meaningful).
Honza
>
> Dave
>
> gcc/ChangeLog:
> PR ipa/93315
> * ipa-profile.c (ipa_profile): Delete call_sums and set it to
> NULL on exit.
> ---
> gcc/ipa-profile.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gcc/ipa-profile.c b/gcc/ipa-profile.c
> index 03272f20987..a69ba0c373a 100644
> --- a/gcc/ipa-profile.c
> +++ b/gcc/ipa-profile.c
> @@ -1023,6 +1023,9 @@ ipa_profile (void)
> if (dump_file && (dump_flags & TDF_DETAILS))
> symtab->dump (dump_file);
>
> + delete call_sums;
> + call_sums = NULL;
> +
> return 0;
> }
>
> --
> 2.21.0
>
next prev parent reply other threads:[~2020-01-21 15:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 9:19 [PATCH v2] Missed function specialization + partial devirtualization Xiong Hu Luo
2019-07-15 8:20 ` Martin Liška
2019-07-31 5:51 ` [PATCH v3] " luoxhu
2019-08-13 13:16 ` Martin Liška
2019-08-13 13:21 ` Martin Liška
2019-09-25 3:46 ` [PATCH v4] " luoxhu
2019-09-25 10:57 ` Martin Liška
2019-09-26 5:24 ` luoxhu
2019-09-26 8:36 ` Martin Liška
2019-09-27 7:13 ` [PATCH v5] " luoxhu
2019-10-16 3:33 ` Ping: " luoxhu
2019-10-22 14:24 ` Martin Liška
2019-11-06 5:06 ` Ping: " luoxhu
2019-11-14 6:01 ` Ping*2: " luoxhu
2019-11-14 9:15 ` Jan Hubicka
2019-11-16 10:14 ` luoxhu
2019-11-18 13:04 ` Martin Liška
2019-12-03 2:31 ` [PATCH v6] " luoxhu
2019-12-18 2:33 ` *Ping* " luoxhu
2019-12-19 13:22 ` Jan Hubicka
2019-12-26 13:42 ` [PATCH v7] " luoxhu
2020-01-10 11:23 ` Jan Hubicka
2020-01-13 8:47 ` luoxhu
2020-01-14 13:37 ` Martin Liška
2020-01-14 14:55 ` luoxhu
2020-01-15 10:44 ` Christophe Lyon
2020-01-15 11:08 ` Martin Liška
2020-01-15 13:17 ` Martin Liška
2020-01-15 13:19 ` Jan Hubicka
2020-01-15 14:48 ` Richard Biener
2020-01-15 14:51 ` Jan Hubicka
2020-01-14 20:14 ` David Malcolm
2020-01-18 0:07 ` [PATCH] ipa-profile.c: reset call_sums state within ipa-profile.c (PR ipa/93315) David Malcolm
2020-01-18 18:29 ` Jan Hubicka
2020-01-21 14:23 ` [PATCH] ipa-profile.c: reset call_sums state within ipa-profile.c (v2; PR 93315) David Malcolm
2020-01-21 15:18 ` Jan Hubicka [this message]
2020-01-21 15:34 ` David Malcolm
2020-01-21 15:39 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121151031.GB4245@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=christophe.lyon@linaro.org \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=luoxhu@linux.ibm.com \
--cc=mliska@suse.cz \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).