From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34954 invoked by alias); 6 Feb 2020 06:07:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 34937 invoked by uid 89); 6 Feb 2020 06:07:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*MI:sk:c8d4a0d, H*i:sk:c8d4a0d, H*f:sk:c8d4a0d, our X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2020 06:07:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580969273; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2PzB4Mbv/D+1P4e+exRf57Dam/qhd5d/Yk6rX8smsag=; b=NFoYC/TQlK0YPs6VX4grkxYY6AFBZKSrzrEnirRSdrcg1Wa+b/WN4U1lVSJpGxdF9P6Ont gEfCEFGfzCfvIHnQ6fL5p6MwKa5i8LDYiY+R8ed90Jp3S+7RXu7AbEXLfd90paiuTLux+w JgRqCl5k2HVpLIPEupPSC5ODFk/0zBQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-120-k3OhA0bSOrGQt-h9pf6AHA-1; Thu, 06 Feb 2020 01:07:50 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EF0441084420; Thu, 6 Feb 2020 06:07:49 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8513E5E240; Thu, 6 Feb 2020 06:07:49 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 01667lL6001886; Thu, 6 Feb 2020 07:07:47 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 01667ktT001885; Thu, 6 Feb 2020 07:07:46 +0100 Date: Thu, 06 Feb 2020 06:07:00 -0000 From: Jakub Jelinek To: JonY <10walls@gmail.com> Cc: Uros Bizjak , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] i386: Make xmm16-xmm31 call used even in ms ABI Message-ID: <20200206060745.GG17695@tucnak> Reply-To: Jakub Jelinek References: <20200204093921.GN17695@tucnak> <20200204114211.GP17695@tucnak> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00316.txt.bz2 On Thu, Feb 06, 2020 at 01:00:36AM +0000, JonY wrote: > On 2/4/20 11:42 AM, Jakub Jelinek wrote: > > Hi! > >=20 > > On Tue, Feb 04, 2020 at 11:16:06AM +0100, Uros Bizjak wrote: > >> I guess that Comment #9 patch form the PR should be trivially correct, > >> but althouhg it looks obvious, I don't want to propose the patch since > >> I have no means of testing it. > >=20 > > I don't have means of testing it either. > > https://docs.microsoft.com/en-us/cpp/build/x64-calling-convention?view= =3Dvs-2019 > > is quite explicit that [xyz]mm16-31 are call clobbered and only xmm6-15= (low > > 128-bits only) are call preserved. > >=20 > > Jonathan, could you please test this if it is sufficient to just change > > CALL_USED_REGISTERS or if e.g. something in the pro/epilogue needs twea= king > > too? Thanks. >=20 > Is this patch testing still required? I just got back from traveling. Yes, our reading of the MS ABI docs show that xmm16-31 are to be call used (not preserved over calls), while in gcc they are currently handled as preserved across the calls. Jakub