From: Jakub Jelinek <jakub@redhat.com>
To: "Harwath, Frederik" <frederik@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Tobias Burnus <tobias@codesourcery.com>,
"Stubbs, Andrew" <ams@codesourcery.com>,
tdevries@suse.de,
Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [PATCH] xfail and improve some failing libgomp tests
Date: Fri, 07 Feb 2020 15:29:00 -0000 [thread overview]
Message-ID: <20200207152929.GU17695@tucnak> (raw)
In-Reply-To: <1ea4c14f-f975-5170-46ac-ada4588c4969@codesourcery.com>
On Fri, Feb 07, 2020 at 09:56:38AM +0100, Harwath, Frederik wrote:
> * {target-32.c, thread-limit-2.c}:
> no "usleep" implemented for nvptx. Cf. https://gcc.gnu.org/PR81690
Please don't, I want to deal with that using declare variant, just didn't
get yet around to finishing the last patch needed for that. Will try next week.
> * target-{33,34}.c:
> no "GOMP_OFFLOAD_async_run" implemented in plugin-nvptx.c. Cf. https://gcc.gnu.org/PR81688
>
> * target-link-1.c:
> omp "target link" not implemented for nvptx. Cf. https://gcc.gnu.org/PR81689
I guess this is ok, though of course the right thing would be to implement
both. There has been even in some PR a suggestion that instead of failing
in nvptx async_run we should just ignore the nowait clause if the plugin
doesn't implement it properly.
Jakub
next prev parent reply other threads:[~2020-02-07 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 8:56 Harwath, Frederik
2020-02-07 15:29 ` Jakub Jelinek [this message]
2020-02-10 7:50 ` Harwath, Frederik
2020-02-10 8:05 ` Jakub Jelinek
2020-02-13 8:04 ` [PATCH] openmp: ignore nowait if async execution is unsupported [PR93481] Harwath, Frederik
2020-02-13 8:31 ` Jakub Jelinek
2020-02-13 9:36 ` Harwath, Frederik
2020-10-05 13:15 ` [PATCH] xfail and improve some failing libgomp tests Tom de Vries
2020-10-06 14:48 ` Tom de Vries
2020-10-06 15:02 ` Jakub Jelinek
2020-10-06 15:45 ` Tom de Vries
2020-10-22 13:19 ` Jakub Jelinek
2020-10-23 8:12 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207152929.GU17695@tucnak \
--to=jakub@redhat.com \
--cc=ams@codesourcery.com \
--cc=frederik@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tdevries@suse.de \
--cc=thomas@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).