From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Toon Moene <toon@moene.org>
Cc: David Malcolm <dmalcolm@redhat.com>,
gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Subject: Re: [PATCH 1/2] analyzer: gfortran testsuite support
Date: Sun, 09 Feb 2020 20:55:00 -0000 [thread overview]
Message-ID: <20200209205511.GA63077@troutmask.apl.washington.edu> (raw)
In-Reply-To: <3fff5fee-8ac0-b3d1-f7cc-b0a2fb7f2754@moene.org>
On Sun, Feb 09, 2020 at 09:15:46PM +0100, Toon Moene wrote:
> On 2/6/20 9:01 PM, David Malcolm wrote:
>
> > PR analyzer/93405 reports an ICE when attempting to use -fanalyzer on
> > certain gfortran code. The second patch in this kit fixes that, but
> > in the meantime I need somewhere to put regression tests for -fanalyzer
> > with gfortran.
> >
> > This patch adds a gfortran.dg/analyzer subdirectory with an analyzer.exp,
> > setting DEFAULT_FFLAGS on the tests run within it.
>
> I have seen no objections against this proposal, so please go ahead.
>
Perhaps, there are no objections because the people who contribute
patches and provide reviews for gfortran have twindled to 1 or 2 people
with sporadic available time. Did you actually review the proposed
changes? If not, how can you rubber stamp this commit? You have a
total of 12 ChangeLog entries over 18 years with the last occurring in
2011, and I do not recall you ever reviewing a patch. Finally, trunk
is in stage 4 (regression fixes & docs only). This does not look like
either.
If I bootstrap gcc with fortran
% mkdir obj
% ../gcc/configure --prefix=$HOME/work --enable-languages=c,fortran \
--enable-bootstrap --enable-checking=yes
% gmake bootstrap
and then do
% cd gcc
% gmake check-fortran
are these analyzer testcases built/executed? Do all architectures
that support gfortran also support the analyzer infrastructure?
--
Steve
next prev parent reply other threads:[~2020-02-09 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 20:02 David Malcolm
2020-02-06 20:01 ` [PATCH 2/2] analyzer: fix ICE with fortran constant arguments (PR 93405) David Malcolm
2020-02-09 20:16 ` [PATCH 1/2] analyzer: gfortran testsuite support Toon Moene
2020-02-09 20:55 ` Steve Kargl [this message]
2020-02-09 21:19 ` David Malcolm
2020-02-10 0:38 ` Steve Kargl
2020-02-10 20:52 ` David Malcolm
2020-02-10 20:57 ` Steve Kargl
2020-02-09 21:37 ` Toon Moene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200209205511.GA63077@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=dmalcolm@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=toon@moene.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).