From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15242 invoked by alias); 9 Feb 2020 20:55:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15220 invoked by uid 89); 9 Feb 2020 20:55:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=H*MI:sk:3fff5fe, H*i:sk:3fff5fe, H*f:sk:3fff5fe, HX-Languages-Length:1464 X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Feb 2020 20:55:13 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id 019KtB4r063294 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 9 Feb 2020 12:55:11 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id 019KtBGI063293; Sun, 9 Feb 2020 12:55:11 -0800 (PST) (envelope-from sgk) Date: Sun, 09 Feb 2020 20:55:00 -0000 From: Steve Kargl To: Toon Moene Cc: David Malcolm , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PATCH 1/2] analyzer: gfortran testsuite support Message-ID: <20200209205511.GA63077@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20200206200144.14304-1-dmalcolm@redhat.com> <3fff5fee-8ac0-b3d1-f7cc-b0a2fb7f2754@moene.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3fff5fee-8ac0-b3d1-f7cc-b0a2fb7f2754@moene.org> X-SW-Source: 2020-02/txt/msg00505.txt.bz2 On Sun, Feb 09, 2020 at 09:15:46PM +0100, Toon Moene wrote: > On 2/6/20 9:01 PM, David Malcolm wrote: > > > PR analyzer/93405 reports an ICE when attempting to use -fanalyzer on > > certain gfortran code. The second patch in this kit fixes that, but > > in the meantime I need somewhere to put regression tests for -fanalyzer > > with gfortran. > > > > This patch adds a gfortran.dg/analyzer subdirectory with an analyzer.exp, > > setting DEFAULT_FFLAGS on the tests run within it. > > I have seen no objections against this proposal, so please go ahead. > Perhaps, there are no objections because the people who contribute patches and provide reviews for gfortran have twindled to 1 or 2 people with sporadic available time. Did you actually review the proposed changes? If not, how can you rubber stamp this commit? You have a total of 12 ChangeLog entries over 18 years with the last occurring in 2011, and I do not recall you ever reviewing a patch. Finally, trunk is in stage 4 (regression fixes & docs only). This does not look like either. If I bootstrap gcc with fortran % mkdir obj % ../gcc/configure --prefix=$HOME/work --enable-languages=c,fortran \ --enable-bootstrap --enable-checking=yes % gmake bootstrap and then do % cd gcc % gmake check-fortran are these analyzer testcases built/executed? Do all architectures that support gfortran also support the analyzer infrastructure? -- Steve