From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: joseph@codesourcery.com (Joseph Myers)
Cc: richard.guenther@gmail.com (Richard Biener),
gcc-patches@gcc.gnu.org (GCC Patches)
Subject: Re: [PATCH] Fix -ffast-math flags handling inconsistencies
Date: Tue, 11 Feb 2020 12:47:00 -0000 [thread overview]
Message-ID: <20200211124750.42F9FD802E4@oc3748833570.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2002102305360.9284@digraph.polyomino.org.uk> from "Joseph Myers" at Feb 10, 2020 11:07:17 PM
Joseph Myers wrote:
> On Mon, 10 Feb 2020, Ulrich Weigand wrote:
> > I'm not sure how this can be implemented in the current option handling
> > framework. The -ffast-math handling case would have to check whether
> > or not there is any explicit use of -f(no-)finite-math-only; is there
> > any infrastructure to readily perform such a test?
>
> Pass opts_set as well as opts to set_fast_math_flags, and use it for
> checking whether an option was explicitly specified (whether enabled or
> disabled) on the command line.
Ah, I see. I'll update the patch accordingly. Thanks!
I guess I still need to check for the opts->frontend_set_... flags
as well -- those are not reflected in opts_set, right?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2020-02-11 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 17:47 Ulrich Weigand
2020-02-05 9:58 ` Richard Biener
2020-02-07 16:47 ` Ulrich Weigand
2020-02-07 22:55 ` Joseph Myers
2020-02-10 16:24 ` Ulrich Weigand
2020-02-10 23:07 ` Joseph Myers
2020-02-11 12:47 ` Ulrich Weigand [this message]
2020-02-08 2:52 ` Segher Boessenkool
2020-02-10 16:27 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211124750.42F9FD802E4@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).