public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Mark Eggleston <mark.eggleston@codethink.co.uk>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [9/10 Regression, PATCH] fortran: ICE in gfc_validate_kind(): Got bad kind [PR93580]
Date: Tue, 11 Feb 2020 15:20:00 -0000	[thread overview]
Message-ID: <20200211152031.GA77655@troutmask.apl.washington.edu> (raw)
In-Reply-To: <802db473-0383-5fe1-2493-4968b133312b@codethink.co.uk>

On Tue, Feb 11, 2020 at 02:41:26PM +0000, Mark Eggleston wrote:
> Please find attached a patch, it is based on Steve Kargl's patch in PR93580
> adding  a check for %len and test case.
> 

Looks like the wrong diff was attached.

>  gcc/fortran/match.c                     | 4 ++--
>  gcc/testsuite/gfortran.dg/pr93484_1.f90 | 8 ++++++++
>  gcc/testsuite/gfortran.dg/pr93484_2.f90 | 8 ++++++++
>  3 files changed, 18 insertions(+), 2 deletions(-)
>  create mode 100644 gcc/testsuite/gfortran.dg/pr93484_1.f90
>  create mode 100644 gcc/testsuite/gfortran.dg/pr93484_2.f90
> 
> diff --git a/gcc/fortran/match.c b/gcc/fortran/match.c
> index a74cb8c5c19..03adfca9bd9 100644
> --- a/gcc/fortran/match.c
> +++ b/gcc/fortran/match.c
> @@ -2222,9 +2222,9 @@ gfc_match_type_spec (gfc_typespec *ts)
>  
>  found:
>  
> -      m = gfc_match_init_expr (&e);
> +      m = gfc_match_expr (&e);
>        if (m == MATCH_NO || m == MATCH_ERROR)
> -	return MATCH_NO;
> +	return m;

-- 
steve

  reply	other threads:[~2020-02-11 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 14:41 Mark Eggleston
2020-02-11 15:20 ` Steve Kargl [this message]
2020-02-11 15:22   ` Mark Eggleston
2020-02-11 15:25 Mark Eggleston
2020-02-17 22:09 ` Thomas Koenig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211152031.GA77655@troutmask.apl.washington.edu \
    --to=sgk@troutmask.apl.washington.edu \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark.eggleston@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).