From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61592 invoked by alias); 12 Feb 2020 07:05:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61580 invoked by uid 89); 12 Feb 2020 07:05:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: smtp2.axis.com Received: from smtp2.axis.com (HELO smtp2.axis.com) (195.60.68.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 07:05:10 +0000 IronPort-SDR: M3iw1ElD7g4Tjq31TLd/amJRVZOD38ZXaABPjeJpOtBLte+CnL8EPtxgCxhozRHcrkLVeWmr+B xIjs2QFJ7D4vLgO8ja5HtUOgVbr7eYrhv4BkzLOPgTEDMYDSLkpgVnDLb7RvnledHByrx6ZhV7 BnqEsnbB5svjZwMbsvfst1mz3uHebutihRaB0Rndb5Z04RCUVuBTqcKkAtyf9LTZgxtg1z3Tgh YMljLCdI7HK35G8IDVmXRSLqrfngST0vIDIGH1hkYJFrXKseXkSIGLAGMzv0fBBpQx4APXm+YG t6k= Date: Wed, 12 Feb 2020 07:05:00 -0000 Message-ID: <202002120705.01C757jv027193@ignucius.se.axis.com> From: Hans-Peter Nilsson To: Subject: [cris-decc0 14/14] cris: Enable "neg" to set condition codes. MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Return-Path: hp@axis.com X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00708.txt.bz2 * config/cris/cris.c (cris_select_cc_mode): Return CC_NZmode for NEG too. Correct comment. * config/cris/cris.md ("neg2"): Rename from "neg2". While gcc seems to prefer transforming tests on the result of reversible operations, into tests on the original, it also can work with the destination, if allocated to the same register as it commonly-enough is. The re-use is easily covered in a test-case. (N.B.: the value 0x80000000 appears to be considered invalid and unimportant.) Spotted as a "microregression" in libgcc when comparing to the cc0 version. --- gcc/config/cris/cris.c | 8 ++++---- gcc/config/cris/cris.md | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/config/cris/cris.c b/gcc/config/cris/cris.c index d0807adc8..2bad9393c 100644 --- a/gcc/config/cris/cris.c +++ b/gcc/config/cris/cris.c @@ -1531,9 +1531,9 @@ cris_select_cc_mode (enum rtx_code op, rtx x, rtx y) return CCmode; /* If we have a comparison that doesn't have to look at V or C, check - operand x; if it looks like a binary operator, return CC_NZmode, - else CCmode, so we only use CC_NZmode for the cases where we don't - actually have both V and C valid. */ + operand x; if it's a valid operator, return CC_NZmode, else CCmode, + so we only use CC_NZmode for the cases where we don't actually have + both V and C valid. */ if (op == EQ || op == NE || op == GTU || op == LEU || op == LT || op == GE) { @@ -1542,7 +1542,7 @@ cris_select_cc_mode (enum rtx_code op, rtx x, rtx y) /* Mentioning the rtx_code here is required but not sufficient: the insn also needs to be decorated with (and the anonymization prefix for a named pattern). */ - return e == PLUS || e == MINUS || e == MULT || e == NOT + return e == PLUS || e == MINUS || e == MULT || e == NOT || e == NEG ? CC_NZmode : CCmode; } diff --git a/gcc/config/cris/cris.md b/gcc/config/cris/cris.md index 1e895a375..081041fa2 100644 --- a/gcc/config/cris/cris.md +++ b/gcc/config/cris/cris.md @@ -1734,7 +1734,7 @@ (define_insn "*expanded_negsf2" ;; No "negdi2" although we could make one up that may be faster than ;; the one in libgcc. -(define_insn "neg2" +(define_insn "neg2" [(set (match_operand:BWD 0 "register_operand" "=r") (neg:BWD (match_operand:BWD 1 "register_operand" "r"))) (clobber (reg:CC CRIS_CC0_REGNUM))] -- 2.11.0 brgds, H-P