From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127720 invoked by alias); 13 Feb 2020 08:53:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127712 invoked by uid 89); 13 Feb 2020 08:53:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*f:sk:NH3coTM, H*f:CAFULd4abDHz-1j, H*i:sk:NH3coTM, H*MI:CAFULd4abDHz-1j X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 08:53:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581584019; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfg6udH8B8u9tR89DR/aqj48yvhQnPNBCOsHa1nEHXE=; b=G3/9mNuZUvVwl+d40Vu7CmdxLhchfRzXYCXnRyuBD+FNxxr7LOo4niTeuvPUTS5Gsrdzmz 2s56YfA/1D9+9aKPBuMV2FAF2pmXswbbXRwRhQjLNSE7pG11uJZErNZQ9GSYTWyp7BUbZ9 UPJQyuSsA0lqJhbqqkx25vU7J0Tw0kE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-XyfMRr-XOTmLlR9RxQp-OQ-1; Thu, 13 Feb 2020 03:53:33 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9EB92800D4C; Thu, 13 Feb 2020 08:53:32 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31F4D1001B28; Thu, 13 Feb 2020 08:53:32 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 01D8rUtD021186; Thu, 13 Feb 2020 09:53:30 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 01D8rTwK021185; Thu, 13 Feb 2020 09:53:29 +0100 Date: Thu, 13 Feb 2020 08:53:00 -0000 From: Jakub Jelinek To: Uros Bizjak Cc: Hongtao Liu , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274] Message-ID: <20200213085329.GG17695@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00775.txt.bz2 On Thu, Feb 13, 2020 at 09:39:05AM +0100, Uros Bizjak wrote: > > Changelog > > gcc/ > > * config/i386/avx512vbmi2intrin.h > > (_mm512_[,mask_,maskz_]shrdi_epi16, > > _mm512_[,mask_,maskz_]shrdi_epi32, > > _m512_[,mask_,maskz_]shrdi_epi64, > > _mm512_[,mask_,maskz_]shldi_epi16, > > _mm512_[,mask_,maskz_]shldi_epi32, > > _m512_[,mask_,maskz_]shldi_epi64): Fix typo of lacking a > > closing parenthesis. > > * config/i386/avx512vbmi2vlintrin.h > > (_mm256_[,mask_,maskz_]shrdi_epi16, > > _mm256_[,mask_,maskz_]shrdi_epi32, > > _m256_[,mask_,maskz_]shrdi_epi64, > > _mm_[,mask_,maskz_]shrdi_epi16, > > _mm_[,mask_,maskz_]shrdi_epi32, > > _mm_[,mask_,maskz_]shrdi_epi64, > > _mm256_[,mask_,maskz_]shldi_epi16, > > _mm256_[,mask_,maskz_]shldi_epi32, > > _m256_[,mask_,maskz_]shldi_epi64, > > _mm_[,mask_,maskz_]shldi_epi16, > > _mm_[,mask_,maskz_]shldi_epi32, > > _mm_[,mask_,maskz_]shldi_epi64): Ditto. > > > > gcc/testsuite/ > > * gcc.target/i386/avx512vbmi2-vpshld-1.c: New test. > > * gcc.target/i386/avx512vbmi2-vpshld-O0-1.c: Ditto. > > * gcc.target/i386/avx512vbmi2-vpshrd-1.c: Ditto. > > * gcc.target/i386/avx512vbmi2-vpshrd-O0-1.c: Ditto. > > * gcc.target/i386/avx512vl-vpshld-O0-1.c: Ditto. > > * gcc.target/i386/avx512vl-vpshrd-O0-1.c: Ditto. >=20 > This is obvious patch, so OK for mainline and backports. The header changes sure, but for the testsuite, the standard way would be to have it covered in the standard tests we have for this. I think that is gcc.target/i386/sse-{13,14,22a,23}.c, so it would be worth trying to figure out why it hasn't caught that. And, I don't think we allow any wildcards etc. (and [,whatever,whateverelse] isn't even one, neither regexp nor shell wildcard) in the names of functions changed, they can appear in the description text, but for the names of macros one needs to list them all expanded, people do grep for those. Jakub