From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91998 invoked by alias); 18 Feb 2020 13:49:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 91815 invoked by uid 89); 18 Feb 2020 13:49:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=undo X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Feb 2020 13:49:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582033749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ckWKboZDOlRP6hPvoMhxPwDfANjJESkWRUbpa0JDm38=; b=am5qpaCLZGsFOeAVcGysmbMILBoOSUhV3RXY19OCh+pV8CG8DyKqUOu9AfWMYgXkB9kCvI F5M1hlKF7ROBycKtrhPy7yjeCYJBsAORF12DByDAWJXiCuUxHa/s/y0uT0KFDmdqhyd+5A 81AWLmDnPjUwBC+sm6F7wrnId2VU53M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-2oikU-J8OfCTB8T9Xp92Tg-1; Tue, 18 Feb 2020 08:49:07 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73A09100F604; Tue, 18 Feb 2020 13:49:06 +0000 (UTC) Received: from localhost (unknown [10.33.36.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DCD690F57; Tue, 18 Feb 2020 13:49:05 +0000 (UTC) Date: Tue, 18 Feb 2020 13:49:00 -0000 From: Jonathan Wakely To: Tim Song Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [committed] libstdc++: P1964R2 Wording for boolean-testable Message-ID: <20200218134905.GA9441@redhat.com> References: <20200217183352.GA1574923@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-SW-Source: 2020-02/txt/msg01038.txt.bz2 On 17/02/20 22:27 +0100, Tim Song wrote: >On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely wrot= e: > >> This removes the complicated std::boolean concept, as agreed in Prague. >> >> * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn) >> (__adjacent_find_fn): Cast result of predicate to bool. > > > >Um, why? These look fine without the cast. (The WP was doing =3D=3D false, >which is a different matter.) Good point, I'll undo those bits. Thanks. >> * include/std/concepts (__boolean): Remove. >> (__detail::__boolean_testable_impl, __detail::__boolean_testable= ): >> Add >> new helper concepts. >> (__detail::__weakly_eq_cmp_with, totally_ordered, >> totally_ordered_with) >> (predicate): Use __boolean_testable instead of boolean. >> * libsupc++/compare (__detail::__partially_ordered, _Synth3way): >> Likewise. >> >> Tested powerpc64le-linux, committed to master. >> >> >