From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: P1983R0 Wording for GB301, US296, US292, US291, and US283
Date: Tue, 18 Feb 2020 23:42:00 -0000 [thread overview]
Message-ID: <20200218234250.GK9441@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.22.395.2002181428170.1723@idea>
On 18/02/20 14:31 -0500, Patrick Palka wrote:
>On Tue, 18 Feb 2020, Patrick Palka wrote:
>
>> Among other changes, P1983R0 resolves LWG 3278 in a different way, so this patch
>> also reverts the already-applied change of LWG 3278.
>>
>> The wording for US283 has already been applied it seems.
>>
>> libstdc++-v3/ChangeLog:
>>
>> P1983R0 Wording for GB301, US296, US292, US291, and US283
>> * include/std/ranges (filter_view::pred): New member function.
>> (join_view::_Iterator::_Iterator): Remove now-redundant comment since
>> P1983R0 fixes the highlighted issue in the same way.
>> (join_view::_M_inner): Remove mutable specifier, effectively reverting
>> the proposed wording changes of P3278.
>> (join_view::begin): Refine the condition for when to return a const
>> iterator.
>> (split_view::_OuterIter::_OuterIter): Adjust constraints.
>> * testsuite/std/ranges/adaptors/filter.cc: Test that filter_view::pred
>> exists and works.
>
>Oops, this patch is incomplete, it breaks the join_view adaptor test due
>to a missing friend, sorry about that. Here's the complete and tested
>patch:
OK for master, thanks.
prev parent reply other threads:[~2020-02-18 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 19:14 Patrick Palka
2020-02-18 19:31 ` Patrick Palka
2020-02-18 23:42 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218234250.GK9441@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).