From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73744 invoked by alias); 24 Feb 2020 10:44:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73701 invoked by uid 89); 24 Feb 2020 10:44:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=day X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2020 10:44:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582541075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7xKCdpkr4KKJm3FHUPkuayjDrAV1ZHUZjkwtMp0M8Y4=; b=W0SHEqA24DYIoS936rOFxaR0Pq4DON56La9IXcPIpb/qFrF/iUWHd6UWKsKnwmEaMHaMPG TPJ2EHIXWYvkyGiO3QOAPyGU5MnrD3lrsvW0rlj9BabQF/GlHU6iuFeb4FcH3QzmKXB6Iz xPkP97nr/P+7MvkC1/YARL4EprjRZl8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-LzJsm-4PNziPDq4hnLqtwQ-1; Mon, 24 Feb 2020 05:44:33 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B275813FF; Mon, 24 Feb 2020 10:44:31 +0000 (UTC) Received: from localhost (unknown [10.33.36.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E3BA60BFB; Mon, 24 Feb 2020 10:44:30 +0000 (UTC) Date: Mon, 24 Feb 2020 10:44:00 -0000 From: Jonathan Wakely To: Ville Voutilainen Cc: gcc-patches List , libstdc++ Subject: Re: [PATCH] libstd++: Library-side tests for parenthesized aggregate init (c++/92878, c++/92947) Message-ID: <20200224104430.GA9441@redhat.com> References: MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-SW-Source: 2020-02/txt/msg01279.txt.bz2 On 23/02/20 15:18 +0200, Ville Voutilainen wrote: >This shebang adds library tests for all cases of parenthesized aggregate >initialization that I could find. Tested locally on Linux-x64, going to >test with full suite on Linux-PPC64, OK for trunk if tests pass? Please add: { dg-do run { target c++2a } } Tests that aren't valid in all modes should be marked as such. Some day I'd like the library tests to be able to run automatically for multiple -std variations, like the front end tests do. To do that we'd want to remove all -std flags from dg-options, and at that point we need the tests to be correctly marked so they won't try to run for -std=3Dc++98 etc. OK with that change if testing passes, thanks.