public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Roman Zhuykov <zhroma@ispras.ru>
Cc: Sandra Loosemore <sandra@codesourcery.com>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	       Richard Sandiford <richard.sandiford@arm.com>,
	       Richard Biener <rguenther@suse.de>,
	       Alexander Monakov <amonakov@ispras.ru>
Subject: Re: [PATCH] issues with configure --enable-checking option
Date: Tue, 25 Feb 2020 08:31:00 -0000	[thread overview]
Message-ID: <20200225083042.GH2155@tucnak> (raw)
In-Reply-To: <b093c54c-fce2-45bc-27ac-0cfd2bf6f119@ispras.ru>

On Tue, Feb 25, 2020 at 11:20:58AM +0300, Roman Zhuykov wrote:
> Sandra and Richard, thank you for review!
> 
> Since 'types' checks are included into 'yes' and I addressed all other
> hints, I have pushed updated patch as r10-6832.
> 
> Jakub, Richard B, can I apply it to 8 and 9 ?

Yes.

> +When the option is not specified, the active set of checks depends on
> context.
> +Namely, bootstrap stage 1 defaults to @samp{--enable-checking=yes}, builds
> +from release archives default to @samp{--enable-checking=release}, and

Is archives the right word?  The --enable-checking=release by default is
turned on whenever it is a release branch, checked by whether gcc/DEV-PHASE
is not experimental, and generally applies to everything but the GCC trunk.

> +The @samp{valgrind} check requires the external @command{valgrind}
> simulator,
> +available from @uref{http://valgrind.org/}.  The @samp{df}, @samp{rtl},
> +@samp{gcac} and @samp{valgrind} checks are very expensive.

I would certainly not say that rtl checking is very expensive, it is
somewhat expensive, but I'm using it in all my bootstraps and others are as
well.  On the other side, fold checking is extremely expensive.

So perhaps

The @samp{rtl} checks are expensive and the @samp{df},
@samp{fold}, @samp{gcac} and @samp{valgrind} checks are very expensive.

?

	Jakub

  reply	other threads:[~2020-02-25  8:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 13:52 Roman Zhuykov
2020-02-04  7:16 ` Roman Zhuykov
2020-02-07 17:20 ` Richard Sandiford
2020-02-11 14:47   ` Roman Zhuykov
2020-02-17 11:01     ` Roman Zhuykov
2020-02-22  3:25     ` Sandra Loosemore
2020-02-25  8:21       ` Roman Zhuykov
2020-02-25  8:31         ` Jakub Jelinek [this message]
2020-02-25 10:36           ` Roman Zhuykov
2020-02-25 10:41             ` Jakub Jelinek
2020-03-10 12:20             ` Roman Zhuykov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200225083042.GH2155@tucnak \
    --to=jakub@redhat.com \
    --cc=amonakov@ispras.ru \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    --cc=richard.sandiford@arm.com \
    --cc=sandra@codesourcery.com \
    --cc=zhroma@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).