From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118919 invoked by alias); 25 Feb 2020 08:31:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118910 invoked by uid 89); 25 Feb 2020 08:31:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*Ad:U*amonakov X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Feb 2020 08:30:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582619458; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mvYEWReB2e44fb4J9LAvKSdxIzWqlcdD95sB3EzW2DE=; b=MJg4LkQQqq5ahc9IfLA21aXj2G+cpfotJrKeOgC6RoLz5p/P/OYyJVfwr52MmW90LrFZdx fipE/CwfyYD4hfrKkUQ/sOfxYsKRsYsX9y8BPOH93MveHfKn1cGGWljXDGKP1OI7JDxW2/ LZUdW1rCFz2aDlUodS5x92Cm8B6yt0Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-24-bMcx0JNMNoKb8WJnC1J2uA-1; Tue, 25 Feb 2020 03:30:51 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C862D800D50; Tue, 25 Feb 2020 08:30:49 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 25F885DA2C; Tue, 25 Feb 2020 08:30:48 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 01P8UkoU022869; Tue, 25 Feb 2020 09:30:46 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 01P8UgQg022868; Tue, 25 Feb 2020 09:30:42 +0100 Date: Tue, 25 Feb 2020 08:31:00 -0000 From: Jakub Jelinek To: Roman Zhuykov Cc: Sandra Loosemore , "gcc-patches@gcc.gnu.org" , Richard Sandiford , Richard Biener , Alexander Monakov Subject: Re: [PATCH] issues with configure --enable-checking option Message-ID: <20200225083042.GH2155@tucnak> Reply-To: Jakub Jelinek References: <540c7900-96e4-d762-56be-6b453a0a38a7@ispras.ru> <2f34ffaf-5038-01bd-4881-262a964e1820@ispras.ru> <7b5774a8-60d0-c36e-efde-8ff88755f50e@codesourcery.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg01365.txt.bz2 On Tue, Feb 25, 2020 at 11:20:58AM +0300, Roman Zhuykov wrote: > Sandra and Richard, thank you for review! >=20 > Since 'types' checks are included into 'yes' and I addressed all other > hints, I have pushed updated patch as r10-6832. >=20 > Jakub, Richard B, can I apply it to 8 and 9 ? Yes. > +When the option is not specified, the active set of checks depends on > context. > +Namely, bootstrap stage 1 defaults to @samp{--enable-checking=3Dyes}, bu= ilds > +from release archives default to @samp{--enable-checking=3Drelease}, and Is archives the right word? The --enable-checking=3Drelease by default is turned on whenever it is a release branch, checked by whether gcc/DEV-PHASE is not experimental, and generally applies to everything but the GCC trunk. > +The @samp{valgrind} check requires the external @command{valgrind} > simulator, > +available from @uref{http://valgrind.org/}.=A0 The @samp{df}, @samp{rtl}, > +@samp{gcac} and @samp{valgrind} checks are very expensive. I would certainly not say that rtl checking is very expensive, it is somewhat expensive, but I'm using it in all my bootstraps and others are as well. On the other side, fold checking is extremely expensive. So perhaps The @samp{rtl} checks are expensive and the @samp{df}, @samp{fold}, @samp{gcac} and @samp{valgrind} checks are very expensive. ? Jakub